Skip to content

Update Deno project init command #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Conversation

mintydev789
Copy link
Contributor

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

This PR updates the Deno command for initializing a Solid project. The current command on the website is no longer the preferred way of initializing projects with Deno. deno init --npm is equivalent to npm init.

Related issues & labels

  • Suggested label(s) (optional): 'documentation'

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented May 29, 2025

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit bbb4af6
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/68389752239e76000981bf2c
😎 Deploy Preview https://deploy-preview-1190--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mintydev789
Copy link
Contributor Author

@amirhhashemi thanks for approving. How does merging work in this repo? I can't merge myself.

@amirhhashemi
Copy link
Collaborator

@mintydev789 One of the maintainers with push access must also approve. This may take some time. You don’t need to do anything else.

Thank you for your contribution.

@LadyBluenotes LadyBluenotes merged commit b155357 into solidjs:main May 30, 2025
7 checks passed
@mintydev789
Copy link
Contributor Author

@mintydev789 One of the maintainers with push access must also approve. This may take some time. You don’t need to do anything else.

Thank you for your contribution.

Okay, thanks!

@mintydev789
Copy link
Contributor Author

@amirhhashemi will this be deployed soon? I'm still not seeing it updated on the website.

@amirhhashemi
Copy link
Collaborator

@mintydev789 It's deployed. But it seems it's not applied everywhere. I will investigate.

@amirhhashemi
Copy link
Collaborator

@mintydev789 Can you please send the link to the page that is not updated? I checked again and I noticed that this PR only updates the init commit. Perhaps the install command also needs to be updated?

@mintydev789
Copy link
Contributor Author

@mintydev789 Can you please send the link to the page that is not updated? I checked again and I noticed that this PR only updates the init commit. Perhaps the install command also needs to be updated?

It's this page: https://start.solidjs.com. It still shows the old run command. Which install command are you referring to?

@amirhhashemi
Copy link
Collaborator

@mintydev789 That page is not part of our docs. Actually, I'm not sure where is its code. I will ask about it and update it myself. Thank you for reporting it.

@mintydev789
Copy link
Contributor Author

@amirhhashemi any update?

@amirhhashemi
Copy link
Collaborator

@mintydev789 Sorry, I forgot about that. Thank you for the reminder. PR: solidjs/solid-start#1910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants