Skip to content

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Nov 27, 2024

pnpm install, build, test

Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: 6c1c1d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@birkskyum birkskyum mentioned this pull request Nov 27, 2024
@atilafassina
Copy link
Member

atilafassina commented Dec 3, 2024

hey, @birkskyum . Maybe stupid question but: do we really need pnpm run build in this CI?
I only see Vitest files in this workflow and I think they pull files from /src


sorry I added workflow_dispatch, I expected to run it on the PR.

@birkskyum
Copy link
Member Author

birkskyum commented Dec 3, 2024

Good catch, it's not needed. Ran i locally just now without the build to make sure, and it's all green. It's removed from the pr

@ryansolid ryansolid merged commit 9a9a6e9 into solidjs:main Dec 4, 2024
@ryansolid
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants