Skip to content

Commit

Permalink
test: use consts/let instead of var/let
Browse files Browse the repository at this point in the history
  • Loading branch information
@aminya
aminya committed Jun 22, 2021
1 parent fa32322 commit 3e7d535
Show file tree
Hide file tree
Showing 5 changed files with 70 additions and 70 deletions.
24 changes: 12 additions & 12 deletions packages/solid/test/mutable.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ describe("Simple update modes", () => {

describe("Unwrapping Edge Cases", () => {
test("Unwrap nested frozen state object", () => {
var state = createMutable({
const state = createMutable({
data: Object.freeze({ user: { firstName: "John", lastName: "Snow" } })
}),
s = unwrap({ ...state });
Expand All @@ -105,7 +105,7 @@ describe("Unwrapping Edge Cases", () => {
expect(s.data.user[$RAW]).toBeUndefined();
});
test("Unwrap nested frozen array", () => {
var state = createMutable({
const state = createMutable({
data: [{ user: { firstName: "John", lastName: "Snow" } }]
}),
s = unwrap({ data: state.data.slice(0) });
Expand All @@ -115,7 +115,7 @@ describe("Unwrapping Edge Cases", () => {
expect(s.data[0].user[$RAW]).toBeUndefined();
});
test("Unwrap nested frozen state array", () => {
var state = createMutable({
const state = createMutable({
data: Object.freeze([{ user: { firstName: "John", lastName: "Snow" } }])
}),
s = unwrap({ ...state });
Expand All @@ -129,8 +129,8 @@ describe("Unwrapping Edge Cases", () => {
describe("Tracking State changes", () => {
test("Track a state change", () => {
createRoot(() => {
var state = createMutable({ data: 2 }),
executionCount = 0;
const state = createMutable({ data: 2 })
let executionCount = 0;

expect.assertions(2);
createComputed(() => {
Expand All @@ -152,10 +152,10 @@ describe("Tracking State changes", () => {

test("Track a nested state change", () => {
createRoot(() => {
var state = createMutable({
const state = createMutable({
user: { firstName: "John", lastName: "Smith" }
}),
executionCount = 0;
})
let executionCount = 0;

expect.assertions(2);
createComputed(() => {
Expand All @@ -178,15 +178,15 @@ describe("Tracking State changes", () => {
describe("Handling functions in state", () => {
test("Array Native Methods: Array.Filter", () => {
createRoot(() => {
var state = createMutable({ list: [0, 1, 2] }),
const state = createMutable({ list: [0, 1, 2] }),
getFiltered = createMemo(() => state.list.filter(i => i % 2));
expect(getFiltered()).toStrictEqual([1]);
});
});

test("Track function change", () => {
createRoot(() => {
var state = createMutable<{ fn: () => number }>({
const state = createMutable<{ fn: () => number }>({
fn: () => 1
}),
getValue = createMemo(() => state.fn());
Expand All @@ -199,7 +199,7 @@ describe("Handling functions in state", () => {
describe("Setting state from Effects", () => {
test("Setting state from signal", () => {
createRoot(() => {
var [getData, setData] = createSignal("init"),
const [getData, setData] = createSignal("init"),
state = createMutable({ data: "" });
createComputed(() => (state.data = getData()));
setData("signal");
Expand All @@ -209,7 +209,7 @@ describe("Setting state from Effects", () => {

test("Select Promise", done => {
createRoot(async () => {
var p = new Promise<string>(resolve => {
const p = new Promise<string>(resolve => {
setTimeout(resolve, 20, "promised");
}),
state = createMutable({ data: "" });
Expand Down
68 changes: 34 additions & 34 deletions packages/solid/test/signals.memo.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ describe("createMemo", () => {
describe("executing propagating", () => {
it("does not trigger downstream computations unless changed", () => {
createRoot(() => {
let [s1, set] = createSignal(1, { equals: false });
const [s1, set] = createSignal(1, { equals: false });
let order = "";
let t1 = createMemo(() => {
const t1 = createMemo(() => {
order += "t1";
return s1();
});
Expand All @@ -26,9 +26,9 @@ describe("createMemo", () => {

it("applies updates to changed dependees in same order as createComputed", () => {
createRoot(() => {
let [s1, set] = createSignal(0);
const [s1, set] = createSignal(0);
let order = "";
let t1 = createMemo(() => {
const t1 = createMemo(() => {
order += "t1";
return s1() === 0;
});
Expand All @@ -50,10 +50,10 @@ describe("createMemo", () => {

it("updates downstream pending computations", () => {
createRoot(() => {
let [s1, set] = createSignal(0);
let [s2] = createSignal(0);
const [s1, set] = createSignal(0);
const [s2] = createSignal(0);
let order = "";
let t1 = createMemo(() => {
const t1 = createMemo(() => {
order += "t1";
return s1() === 0;
});
Expand All @@ -77,11 +77,11 @@ describe("createMemo", () => {
});

describe("with changing dependencies", () => {
var i: () => boolean, setI: (v: boolean) => void;
var t: () => number, setT: (v: number) => void;
var e: () => number, setE: (v: number) => void;
var fevals: number;
var f: () => number;
let i: () => boolean, setI: (v: boolean) => void;
let t: () => number, setT: (v: number) => void;
let e: () => number, setE: (v: number) => void;
let fevals: number;
let f: () => number;

function init() {
[i, setI] = createSignal<boolean>(true);
Expand Down Expand Up @@ -177,8 +177,8 @@ describe("createMemo", () => {
describe("with intercepting computations", () => {
it("does not update subsequent pending computations after stale invocations", () => {
createRoot(() => {
let [s1, set1] = createSignal(1);
let [s2, set2] = createSignal(false);
const [s1, set1] = createSignal(1);
const [s2, set2] = createSignal(false);
let count = 0;
/*
s1
Expand All @@ -189,12 +189,12 @@ describe("createMemo", () => {
c3
[PN,PN,STL,void]
*/
let t1 = createMemo(() => s1() > 0);
let t2 = createMemo(() => s1() > 0);
let c1 = createMemo(() => s1());
let t3 = createMemo(() => {
let a = s1();
let b = s2();
const t1 = createMemo(() => s1() > 0);
const t2 = createMemo(() => s1() > 0);
const c1 = createMemo(() => s1());
const t3 = createMemo(() => {
const a = s1();
const b = s2();
return a && b;
});
createComputed(() => {
Expand Down Expand Up @@ -252,8 +252,8 @@ describe("createMemo", () => {

it("evaluates nested trackings", () => {
createRoot(() => {
let [s1, set1] = createSignal(1);
let [s2] = createSignal(1);
const [s1, set1] = createSignal(1);
const [s2] = createSignal(1);
let count = 0;
let c1: () => number;
createMemo(() => {
Expand All @@ -271,13 +271,13 @@ describe("createMemo", () => {

it("propagates in topological order", () => {
createRoot(() => {
let [s1, set] = createSignal(true);
const [s1, set] = createSignal(true);
let order = "";
let t1 = createMemo(() => {
const t1 = createMemo(() => {
order += "t1";
return s1();
});
let t2 = createMemo(() => {
const t2 = createMemo(() => {
order += "t2";
return s1();
});
Expand All @@ -294,7 +294,7 @@ describe("createMemo", () => {

it("does not evaluate dependencies with tracking sources that have not changed", () => {
createRoot(() => {
let [s1, set] = createSignal(1);
const [s1, set] = createSignal(1);
let order = "";
let c2: () => boolean;
createComputed(() => {
Expand All @@ -303,11 +303,11 @@ describe("createMemo", () => {
c2();
}
});
let t1 = createMemo(() => {
const t1 = createMemo(() => {
order += "t1";
return s1() < 3;
});
let t2 = createMemo(() => {
const t2 = createMemo(() => {
order += "t2";
return t1();
});
Expand All @@ -326,17 +326,17 @@ describe("createMemo", () => {

it("correctly marks downstream computations as stale on change", () => {
createRoot(() => {
let [s1, set] = createSignal(1);
const [s1, set] = createSignal(1);
let order = "";
let t1 = createMemo(() => {
const t1 = createMemo(() => {
order += "t1";
return s1();
});
let c1 = createMemo(() => {
const c1 = createMemo(() => {
order += "c1";
return t1();
});
let c2 = createMemo(() => {
const c2 = createMemo(() => {
order += "c2";
return c1();
});
Expand All @@ -354,7 +354,7 @@ describe("createMemo", () => {
describe("with unending changes", () => {
it("throws when continually setting a direct dependency", () => {
createRoot(() => {
var [d, set] = createSignal(1);
const [d, set] = createSignal(1);

expect(() => {
createMemo(() => {
Expand All @@ -367,7 +367,7 @@ describe("createMemo", () => {
it("throws when continually setting an indirect dependency", () => {
createRoot(() => {
let i = 2;
var [d, set] = createSignal(1),
const [d, set] = createSignal(1),
f1 = createMemo(() => d()),
f2 = createMemo(() => f1()),
f3 = createMemo(() => f2());
Expand Down
36 changes: 18 additions & 18 deletions packages/solid/test/state.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ describe("Array setState modes", () => {

describe("Unwrapping Edge Cases", () => {
test("Unwrap nested frozen state object", () => {
var [state] = createState({
const [state] = createState({
data: Object.freeze({ user: { firstName: "John", lastName: "Snow" } })
}),
s = unwrap({ ...state });
Expand All @@ -163,7 +163,7 @@ describe("Unwrapping Edge Cases", () => {
expect(s.data.user[$RAW]).toBeUndefined();
});
test("Unwrap nested frozen array", () => {
var [state] = createState({
const [state] = createState({
data: [{ user: { firstName: "John", lastName: "Snow" } }]
}),
s = unwrap({ data: state.data.slice(0) });
Expand All @@ -173,7 +173,7 @@ describe("Unwrapping Edge Cases", () => {
expect(s.data[0].user[$RAW]).toBeUndefined();
});
test("Unwrap nested frozen state array", () => {
var [state] = createState({
const [state] = createState({
data: Object.freeze([{ user: { firstName: "John", lastName: "Snow" } }])
}),
s = unwrap({ ...state });
Expand All @@ -187,8 +187,8 @@ describe("Unwrapping Edge Cases", () => {
describe("Tracking State changes", () => {
test("Track a state change", () => {
createRoot(() => {
var [state, setState] = createState({ data: 2 }),
executionCount = 0;
const [state, setState] = createState({ data: 2 });
let executionCount = 0;

expect.assertions(2);
createComputed(() => {
Expand All @@ -211,10 +211,10 @@ describe("Tracking State changes", () => {

test("Track a nested state change", () => {
createRoot(() => {
var [state, setState] = createState({
const [state, setState] = createState({
user: { firstName: "John", lastName: "Smith" }
}),
executionCount = 0;
});
let executionCount = 0;

expect.assertions(2);
createComputed(() => {
Expand All @@ -235,8 +235,8 @@ describe("Tracking State changes", () => {

test("Tracking Object key addition/removal", () => {
createRoot(() => {
var [state, setState] = createState<{ obj: { item?: number } }>({ obj: {} }),
executionCount = 0;
const [state, setState] = createState<{ obj: { item?: number } }>({ obj: {} });
let executionCount = 0;

createComputed(on(() => state.obj, (v) => {
if (executionCount === 0) expect(v.item).toBeUndefined();
Expand Down Expand Up @@ -264,15 +264,15 @@ describe("Tracking State changes", () => {
describe("Handling functions in state", () => {
test("Array Native Methods: Array.Filter", () => {
createRoot(() => {
var [state] = createState({ list: [0, 1, 2] }),
const [state] = createState({ list: [0, 1, 2] }),
getFiltered = createMemo(() => state.list.filter(i => i % 2));
expect(getFiltered()).toStrictEqual([1]);
});
});

test("Track function change", () => {
createRoot(() => {
var [state, setState] = createState<{ fn: () => number }>({
const [state, setState] = createState<{ fn: () => number }>({
fn: () => 1
}),
getValue = createMemo(() => state.fn());
Expand All @@ -285,7 +285,7 @@ describe("Handling functions in state", () => {
describe("Setting state from Effects", () => {
test("Setting state from signal", () => {
createRoot(() => {
var [getData, setData] = createSignal("init"),
const [getData, setData] = createSignal("init"),
[state, setState] = createState({ data: "" });
createComputed(() => setState("data", getData()));
setData("signal");
Expand All @@ -295,10 +295,10 @@ describe("Setting state from Effects", () => {

test("Select Promise", done => {
createRoot(async () => {
var p = new Promise<string>(resolve => {
const p = new Promise<string>(resolve => {
setTimeout(resolve, 20, "promised");
}),
[state, setState] = createState({ data: "" });
});
const [state, setState] = createState({ data: "" });
p.then(v => setState("data", v));
await p;
expect(state.data).toBe("promised");
Expand Down Expand Up @@ -333,7 +333,7 @@ describe("Array length", () => {
const [state, setState] = createState<{ list: number[] }>({ list: [] });
let length;
// isolate length tracking
let list = state.list;
const list = state.list;
createRoot(() => {
createComputed(() => {
length = list.length;
Expand All @@ -348,7 +348,7 @@ describe("Array length", () => {

describe("State recursion", () => {
test("there is no infinite loop", () => {
let x: { a: number; b: any } = { a: 1, b: undefined };
const x: { a: number; b: any } = { a: 1, b: undefined };
x.b = x;

const [state, setState] = createState(x);
Expand Down
Loading

0 comments on commit 3e7d535

Please sign in to comment.