Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export more solid-js types #1847

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

thetarnav
Copy link
Contributor

These types are useful for library development. Otherwise they have to be imported like this:

import type {
  ResolvedJSXElement,
  ResolvedChildren,
  ContextProviderComponent,
} from "../node_modules/solid-js/types/reactive/signal.js";

So it makes sense to export them unless they are mean to be internal only.

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

🦋 Changeset detected

Latest commit: 7453017

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
solid-js Patch
test-integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid ryansolid merged commit 5ed448a into solidjs:main Aug 8, 2023
1 check passed
@thetarnav thetarnav deleted the export-types branch August 8, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants