Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPLETED/IN DRAFT: Italian translation #537

Merged
merged 5 commits into from
Jul 18, 2021
Merged

Conversation

davedbase
Copy link
Member

Phew, what did I get myself into. Technical translation is more rigorous than I expected. So if there are any native speakers to revise/adapt please feel free to join in or get in touch with me.

@coveralls
Copy link

coveralls commented Jul 4, 2021

Pull Request Test Coverage Report for Build 1041207674

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 35 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 90.249%

Files with Coverage Reduction New Missed Lines %
packages/solid/src/render/component.ts 4 64.95%
packages/solid/src/reactive/signal.ts 31 88.71%
Totals Coverage Status
Change from base Build 995566219: 0.05%
Covered Lines: 1063
Relevant Lines: 1128

💛 - Coveralls

@davedbase
Copy link
Member Author

@fgandellini ho notato che ti e piaciuto il mio commento. Ho finito gli ultimi documenti ma non mi sento sicuro nel prodotto. Potete per favore aiutarmi?? Il mio italiano non e eccezionale ma ho fatto del mio meglio. Sarebbe grande se un madrelingua corregga il contesto tecnico!

@davedbase davedbase changed the title WIP: Italian translation COMPLETED/IN DRAFT: Italian translation Jul 17, 2021
@davedbase davedbase merged commit c4b31d8 into solidjs:main Jul 18, 2021
@fgandellini
Copy link

Hey @davedbase! I'm on holiday these days but as soon as I'll be back I'll be happy to take a look to you documents! 🙂

I'm really interested in this project but I didn't have time to properly use it yet, checking your docs is a great starting point! 😉

@davedbase
Copy link
Member Author

@fgandellini amazing! No rush and I'd be so appreciative. I have no idea how Italians translate code or context of certain topics. So I likely butchered a lot of that and could use a deep look. Also note that we moved all documentation over to https://github.com/solidjs/solid-docs/tree/main/it. =)

Buona vacanza!

@fgandellini
Copy link

Hey @davedbase! I'm back from the holidays, ready for some translation work! 😉
Should I review the translations directly on https://github.com/solidjs/solid-docs/tree/main/it? Or should I update them in this repo?

@davedbase
Copy link
Member Author

Welcome back! Thanks so much for helping make corrections. I'm sure you'll find a lot of the phrasing and even grammar off. I had to lean on my poor language education and Google Translate to make things work decently haha.

If you can, you should fork the repo, make adjusts to the markdown files in it and then Pull Request it back to the solid-docs repo :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants