Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): fix traversed returning duplicate values #843

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

otonashixav
Copy link
Contributor

@otonashixav otonashixav commented Feb 9, 2022

Fixes #840

Also made the type of traversed reflect the keys traversed e.g. Will make a PR after the other store type PRs are done

setStore("list", [0, 1], (v, traversed) => {
  traversed[0]; // <-- number
  traversed[1]; // <-- "list"
})

@coveralls
Copy link

coveralls commented Feb 9, 2022

Pull Request Test Coverage Report for Build 1819805147

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 89.447%

Totals Coverage Status
Change from base Build 1811033532: -0.004%
Covered Lines: 1201
Relevant Lines: 1282

💛 - Coveralls

@otonashixav otonashixav marked this pull request as draft February 9, 2022 18:27
@otonashixav
Copy link
Contributor Author

otonashixav commented Feb 9, 2022

I left #824 in this by accident, going to just keep it to fixing traversed and leave the types to later

Edit: done

@otonashixav otonashixav marked this pull request as ready for review February 9, 2022 18:37
@ryansolid
Copy link
Member

Thanks. Looks good.

@ryansolid ryansolid merged commit 5dd90c4 into solidjs:main Feb 10, 2022
@otonashixav otonashixav deleted the fix-set-store-traversed branch March 15, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

traversed in setStore duplicates traversed keys when passed an array, function or object
3 participants