Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change the signal setter type to show clearer type errors #880

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

otonashixav
Copy link
Contributor

The effects of this change are viewable here: https://tsplay.dev/WkMnDN

@coveralls
Copy link

coveralls commented Mar 9, 2022

Pull Request Test Coverage Report for Build 1988634838

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.275%

Totals Coverage Status
Change from base Build 1950433993: 0.02%
Covered Lines: 1211
Relevant Lines: 1294

💛 - Coveralls

@otonashixav otonashixav deleted the improve-setter-type branch March 15, 2022 18:44
@otonashixav otonashixav restored the improve-setter-type branch March 15, 2022 18:45
@otonashixav otonashixav reopened this Mar 15, 2022
@ryansolid ryansolid merged commit c9c8496 into solidjs:main Mar 15, 2022
@ryansolid ryansolid added the typescript relating to typescript or types label Apr 6, 2022
@otonashixav otonashixav deleted the improve-setter-type branch April 28, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript relating to typescript or types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants