Allow reuse of payment sources via admin #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainerdema
force-pushed
the
rainerd/support-stripe-payment-creation-in-solidus-backend
branch
3 times, most recently
from
2accbfc
to
256ff7e
Compare
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
+ Coverage 99.59% 99.62% +0.03%
==========================================
Files 27 30 +3
Lines 489 540 +51
==========================================
+ Hits 487 538 +51
Misses 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rainerdema
force-pushed
the
rainerd/support-stripe-payment-creation-in-solidus-backend
branch
5 times, most recently
from
8a0c877
to
2186d27
Compare
elia
reviewed
Apr 17, 2023
rainerdema
force-pushed
the
rainerd/support-stripe-payment-creation-in-solidus-backend
branch
2 times, most recently
from
98378cd
to
140bfbc
Compare
There was a problem hiding this comment.
Thanks, @rainerdema! Great work and great investigation 👏 Left some comments.
rainerdema
force-pushed
the
rainerd/support-stripe-payment-creation-in-solidus-backend
branch
from
140bfbc
to
55fbb3c
Compare
This is needed to allow the use of the payment method in the admin interface.
This commit re-introduce the `authorize` and `purchase` methods as they are now handled also backend-side.
rainerdema
force-pushed
the
rainerd/support-stripe-payment-creation-in-solidus-backend
branch
from
55fbb3c
to
3552394
Compare
rainerdema
force-pushed
the
rainerd/support-stripe-payment-creation-in-solidus-backend
branch
from
3552394
to
c8c289a
Compare
This commit adds the Stripe source form partial with only the option to reuse existing payment sources. In addition, a logic similar to the one used in the front end is also implemented to render custom partials for each type of Stripe Payment Method.
This is important to prevent reusing intents with different amount.
rainerdema
force-pushed
the
rainerd/support-stripe-payment-creation-in-solidus-backend
branch
from
c8c289a
to
33b0ad4
Compare
rainerdema
deleted the
rainerd/support-stripe-payment-creation-in-solidus-backend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ℹ️ Please refer to #280 for more details about specific implementation decisions.
This enables the reuse of payment sources within the user's wallet (preventing the use of payment methods that the user has removed from their wallet).
authorizeandpurchasegateway methodsChecklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: