Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Did you forget to push tags to GH repository? #213

Closed
zekefast opened this issue Oct 11, 2013 · 16 comments
Closed

Did you forget to push tags to GH repository? #213

zekefast opened this issue Oct 11, 2013 · 16 comments
Labels

Comments

@zekefast
Copy link

Please, push tags for versions on rubygems.org to GitHub, at least for latest 1.0.0.rc2.

Thank you in advance!

@solnic
Copy link
Owner

solnic commented Oct 11, 2013

Damn :/ Yeah I forgot about tags

On Fri, Oct 11, 2013 at 3:49 PM, Zeke Fast notifications@github.com
wrote:

Please, push tags for versions on rubygems.org to GitHub, at least for latest 1.0.0.rc2.

Thank you in advance!

Reply to this email directly or view it on GitHub:
#213

@zekefast
Copy link
Author

You can just use --tags option with git push when pushing on GH. ;)

@solnic
Copy link
Owner

solnic commented Oct 13, 2013

Do you know what's the easiest way to find sha1 for releases?

@zekefast
Copy link
Author

Do you mean having code find sha1 for it? I think it's impossible exactly determine the commit by code, because even same code committed on different time has different hashes. If you have no tags for previous releases and I'm the only who notice that. I'd suggest don't bothering with tagging and just pay attention to this in future or use git bisect to find commit sure and tag it sure if you have sing of release (like version bump in files or release notes).

@solnic
Copy link
Owner

solnic commented Oct 13, 2013

I always tag releases. I forgot this time because it was a pre-release and I was in rush :(

On Sun, Oct 13, 2013 at 4:43 PM, Zeke Fast notifications@github.com
wrote:

Do you mean having code find sha1 for it? I think it's impossible exactly determine the commit by code, because even same code committed on different time has different hashes. If you have no tags for previous releases and I'm the only who notice that. I'd suggest don't bothering with tagging and just pay attention to this in future or use git bisect to find commit sure and tag it sure if you have sing of release (like version bump in files or release notes).

Reply to this email directly or view it on GitHub:
#213 (comment)

@dkubb
Copy link
Collaborator

dkubb commented Oct 13, 2013

I try to use gem release --tag, but I forget the switch sometimes. I wish it was the default or there was a way to configure it to be the default.

@GBH
Copy link

GBH commented Oct 16, 2013

@dkubb alias gem-release="gem release --tag"

@mbj
Copy link
Collaborator

mbj commented Oct 16, 2013

Lets move this to devtools ;) devtools release ?

@dkubb
Copy link
Collaborator

dkubb commented Oct 16, 2013

@GBH oh right! good call.

@mbj Yeah, that wouldn't be so bad.. I guess using an alias will deal with a lot of the pain though.

@solnic
Copy link
Owner

solnic commented Oct 16, 2013

I don't use gem release - what does it do exactly?

@GBH
Copy link

GBH commented Oct 16, 2013

@solnic It's this thing: https://github.com/svenfuchs/gem-release I ditched jeweler for this and I really like it.

@dkubb
Copy link
Collaborator

dkubb commented Oct 16, 2013

Yeah, it's a nice single purpose library. It adds the "release" command to gem. With the --tag switch it will add a version tag at the same time it pushes to rubygems.

@solnic
Copy link
Owner

solnic commented Oct 16, 2013

I just recalled I used to use it and then I stopped, not sure why.

@elskwid
Copy link
Collaborator

elskwid commented Oct 23, 2013

Seems like just tagging the shas where the version was bumped would do it. https://github.com/solnic/virtus/commits/master/lib/virtus/version.rb

@elskwid
Copy link
Collaborator

elskwid commented Oct 25, 2013

@zekefast, I'm closing this issue now. If you need access to these tags for any reason, please let me know, otherwise, I'm going to leave it be since 1.0 has been released.

@elskwid elskwid closed this as completed Oct 25, 2013
@zekefast
Copy link
Author

@elskwid, Since 1.0 was released this is Okay. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants