Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/control-plane: Update to have max grpc size actual respected thro… #540

Closed
wants to merge 1 commit into from
Closed

pkg/control-plane: Update to have max grpc size actual respected thro… #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions changelog/v0.30.10/maxgrpcrecv-client.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
changelog:
- type: FIX
issueLink: https://github.com/solo-io/gloo/issues/8135
resolvesIssue: false
description: >-
More max recv size fixes for grpc

3 changes: 2 additions & 1 deletion pkg/api/v1/control-plane/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package client

import (
"context"
"math"

status "google.golang.org/genproto/googleapis/rpc/status"
"google.golang.org/grpc/codes"
Expand Down Expand Up @@ -89,7 +90,7 @@ func NewClient(nodeinfo *envoy_api_v2_core.Node, rtype TypeRecord, apply func(ca

func (c *client) Start(ctx context.Context, cc *grpc.ClientConn) error {
client := solo_discovery.NewSoloDiscoveryServiceClient(cc)
resourceclient, err := client.StreamAggregatedResources(ctx)
resourceclient, err := client.StreamAggregatedResources(ctx, grpc.MaxCallRecvMsgSize(int(math.MaxInt)))
if err != nil {
return err
}
Expand Down