K8s 1.27 upgrade #546
Merged
K8s 1.27 upgrade #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
|
/kick |
sheidkamp
commented
Jul 21, 2023
| @@ -138,7 +138,7 @@ func (c *Controller) processNextWorkItem() bool { | |||
| } | |||
| switch e.eventType { | |||
| case added: | |||
| c.handler.OnAdd(e.new) | |||
There was a problem hiding this comment.
Note: this was the only manual change to the go code.
There was a problem hiding this comment.
Interesting change! kubernetes/kubernetes#113763
nfuden
reviewed
Jul 21, 2023
nfuden
reviewed
Jul 21, 2023
sam-heilbron
approved these changes
Jul 21, 2023
nfuden
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to support kubes 1.27 upgrade.
See https://github.com/solo-io/solo-projects/pull/5200 for more info.