-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8s 1.27 upgrade #546
K8s 1.27 upgrade #546
Conversation
Issues linked to changelog: |
/kick |
@@ -138,7 +138,7 @@ func (c *Controller) processNextWorkItem() bool { | |||
} | |||
switch e.eventType { | |||
case added: | |||
c.handler.OnAdd(e.new) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this was the only manual change to the go code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting change! kubernetes/kubernetes#113763
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Since solo-kit is relied on so heavily by gloo, can you link the gloo PR in this solo-kit PR so we can see how these changes are pulled in?
Changes to support kubes 1.27 upgrade.
See https://github.com/solo-io/solo-projects/pull/5200 for more info.