Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s 1.27 upgrade #546

Merged
merged 22 commits into from
Jul 21, 2023
Merged

K8s 1.27 upgrade #546

merged 22 commits into from
Jul 21, 2023

Conversation

sheidkamp
Copy link
Contributor

@sheidkamp sheidkamp commented Jul 10, 2023

Changes to support kubes 1.27 upgrade.

See https://github.com/solo-io/solo-projects/pull/5200 for more info.

@solo-changelog-bot
Copy link

Issues linked to changelog:
solo-io/gloo#8164

@sheidkamp sheidkamp marked this pull request as ready for review July 20, 2023 19:33
@sheidkamp
Copy link
Contributor Author

/kick

@@ -138,7 +138,7 @@ func (c *Controller) processNextWorkItem() bool {
}
switch e.eventType {
case added:
c.handler.OnAdd(e.new)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this was the only manual change to the go code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting change! kubernetes/kubernetes#113763

Copy link
Contributor

@sam-heilbron sam-heilbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Since solo-kit is relied on so heavily by gloo, can you link the gloo PR in this solo-kit PR so we can see how these changes are pulled in?

cloudbuild-cache.yaml Outdated Show resolved Hide resolved
@soloio-bulldozer soloio-bulldozer bot merged commit fd91a0c into main Jul 21, 2023
@soloio-bulldozer soloio-bulldozer bot deleted the k8s-1.27-upgrade branch July 21, 2023 19:17
@sheidkamp sheidkamp mentioned this pull request Aug 8, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants