Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "implement json.Marshaler in snapshot templates" #556

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

arianaw66
Copy link
Contributor

@arianaw66 arianaw66 commented Jun 17, 2024

Reverts #554

#554 was originally added for solo-io/gloo#6494.
That issue was then resolved without the change and the solo-kit release with the change (v0.35.1) was not pulled into the gloo repo.
When the subsequent solo-kit release was pulled into the gloo repo for the sake of https://github.com/solo-io/gloo-mesh-enterprise/issues/16010, build-bot started failing due to the changes in #554 (see solo-io/gloo#9626 (comment) and the later runs in solo-io/gloo#9481 - starting at 1ccc94e).
Since #554 is unused and causing failures, this PR reverts it to unblock https://github.com/solo-io/gloo-mesh-enterprise/issues/16010.

Unused code. See context in solo-io/gloo#9517 (comment) and https://solo-io-corp.slack.com/archives/C03MFATU265/p1717090249764499?thread_ts=1716855640.471419&channel=C03MFATU265&message_ts=1717090249.764499

jbohanon
jbohanon previously approved these changes Jun 17, 2024
@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/gloo-mesh-enterprise/issues/16010

@sam-heilbron
Copy link
Contributor

This is a simple commit revert, and @jbohanon will be OOO tomorrow, so I am moving forward and merging this PR so that we do not block @arianaw66 progress

@sam-heilbron sam-heilbron merged commit 1baf6de into main Jun 17, 2024
2 checks passed
@arianaw66 arianaw66 deleted the revert-554-jbohanon/json-snapshots branch June 17, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants