[pull] main from hashicorp:main #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Complete the remaining provider implementations to satisfy the updated internal interface as well as the new protobuf interfaces.
* add tests that highlight known issues in the destroy mechanism * stacks: stacks destroy ordering should match Terraform
Add `Resource` to all the ephemeral protocol symbols to make them consistent with existing naming conventions.
Add protobuf definitions for the ephemeral RPCs
Implement the core nodes for ephemeral resources. This constitutes what's needed for execution, but does not yet include all the necessary graph transformations.
There's still some duplicated code in here, we'll try and sort that out in a later refactor. Ephemeral resources are not currently working with deferrals.
TODOs: - deferrals (still) - The prune transformer needs to take care of ephemerals too in order to continue partial destroys - ValidateEphemeralResourceConfig is not yet called during validate walk.
Call ValidateEphemeralResourcConfig during validation walk. Found that marks don't show up during validation, which may be an HCL bug
…me-role backend/s3: Remove deprecated assume role attributes
…ole.[*].role_arn`
Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>
core: check preconditions and postconditions for ephemeral resources
…_block cloud: Allows object tag schema for selecting key/value tagged workspaces
* Merge to main * fix * Apply suggestions from code review Co-authored-by: Robin Norwood <robin.norwood@gmail.com> * Apply suggestions from code review Co-authored-by: Robin Norwood <robin.norwood@gmail.com> * Terraform format * Small fix * Add ephemeral resources page * Update website/docs/language/values/locals.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/values/locals.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/values/locals.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/values/locals.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/ephemeral.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Updates from review feedback * Add the finishing touches * Add terraform applying * Halfway through * Fix the links * One more pass of resources * Almost done only inputs outputs and locals to go * Finish inputs and outputs * Apply suggestions from code review Co-authored-by: Robin Norwood <rnorwood@hashicorp.com> * Add feedback * Make example small for now * Apply suggestions from code review Co-authored-by: Austin Valle <austinvalle@gmail.com> * Update website/docs/language/state/sensitive-data.mdx * Add example to ephemeral resource page * Reference ephemeral values in provisioner and connection blocks * Correct output command docs * Update website/docs/language/resources/provisioners/syntax.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Update website/docs/language/resources/provisioners/syntax.mdx Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * Reference provisioners and connection blocks * Apply suggestions from code review Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com> --------- Co-authored-by: Robin Norwood <robin.norwood@gmail.com> Co-authored-by: Robin Norwood <rnorwood@hashicorp.com> Co-authored-by: Austin Valle <austinvalle@gmail.com> Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
It turns out the reuse of the plan nodes for ephemerals during apply was interfering with how checks are handled in the plan. Since checks already have an established pattern of use, we can avoid the whole issue by using only the resource apply nodes to kick of ephemeral values. This copies the subset of expansion logic needed from the resource plan node into the apply node. Since the apply time evaluation is much simpler, duplicated code is not overly complex, but we may want to revisit this for refactoring in the future.
We can't enforce the check of the close flag in mocked ephemeral resources, since multiple instances could call the close method while other instances are running.
Ephemeral instances are only removed as whole resources, so there should not be missing instances from an ephemeral resource. We can't error on missing instances, because evaluation of checks may be pulling only a single instance for evaluation before other sibling instances have been opened.
Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>
…checkable add discrete codepaths for ephemeral apply nodes
…35938) Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>
…k-tags-behavior-in-1-10 cloud: document resource k/v tag usage
* stacks: load credentials from config file on startup * delete unneeded file
* Bump github.com/golang-jwt/jwt/v4 from 4.5.0 to 4.5.1 Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.5.0 to 4.5.1. - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v4.5.0...v4.5.1) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * sync deps --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )