-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Home Updates #88
Merged
Merged
App Home Updates #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new section to the app_home layout, introducing the current status of "So Make It" and its respective styles. Updated button styles based on space state. Extended functionality in the get_app_home function and 'space_open'/'space_closed' actions, implementing view republishing upon state changes for accurate display.
The button labels for the space open/close plugin have been updated with emoji indicators. This offers an easy visual cue for the user, enhancing user interface usability. Unused comments and code have also been cleaned up.
The button labels for the space open/close plugin have been updated with emoji indicators. This offers an easy visual cue for the user, enhancing user interface usability. Unused comments and code have also been cleaned up.
The commit updates how the status of the space is represented on the open and closed buttons, enhancing user experience and making the status more distinguishable. Moreover, it modifies the contributing link's URL to point to the 'develop' branch instead of 'master'.
The logic for setting button highlights for the `open_button` and `closed_button` in the Slack application home page has been improved. The buttons now more accurately reflect when the space is open, closed or when the status is unknown.
The parameters for establishing a database connection have been updated to improve the connection setup in the `__init__.py` of the Slack database interface. Specifically, direct connection flag has been added resulting in a more reliable and efficient database connection.
The logic determining the state of open/close buttons in the 'space' section of the application has been corrected in `app_home.py`. They will now highlight properly based on the current status of the space, improving user experience.
@sjefferson99 ready for review |
sjefferson99
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like sensible structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #71 and #72