Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Home Updates #88

Merged
merged 7 commits into from
May 15, 2024
Merged

App Home Updates #88

merged 7 commits into from
May 15, 2024

Conversation

sam57719
Copy link
Collaborator

Implements #71 and #72

Added a new section to the app_home layout, introducing the current status of "So Make It" and its respective styles. Updated button styles based on space state. Extended functionality in the get_app_home function and 'space_open'/'space_closed' actions, implementing view republishing upon state changes for accurate display.
The button labels for the space open/close plugin have been updated with emoji indicators. This offers an easy visual cue for the user, enhancing user interface usability. Unused comments and code have also been cleaned up.
The button labels for the space open/close plugin have been updated with emoji indicators. This offers an easy visual cue for the user, enhancing user interface usability. Unused comments and code have also been cleaned up.
The commit updates how the status of the space is represented on the open and closed buttons, enhancing user experience and making the status more distinguishable. Moreover, it modifies the contributing link's URL to point to the 'develop' branch instead of 'master'.
The logic for setting button highlights for the `open_button` and `closed_button` in the Slack application home page has been improved. The buttons now more accurately reflect when the space is open, closed or when the status is unknown.
@sam57719 sam57719 linked an issue May 15, 2024 that may be closed by this pull request
The parameters for establishing a database connection have been updated to improve the connection setup in the `__init__.py` of the Slack database interface. Specifically, direct connection flag has been added resulting in a more reliable and efficient database connection.
The logic determining the state of open/close buttons in the 'space' section of the application has been corrected in `app_home.py`. They will now highlight properly based on the current status of the space, improving user experience.
@sam57719
Copy link
Collaborator Author

@sjefferson99 ready for review

Copy link
Member

@sjefferson99 sjefferson99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like sensible structure.

@sjefferson99 sjefferson99 merged commit f7b387e into develop May 15, 2024
@sjefferson99 sjefferson99 deleted the 72-app-home-git-links branch May 15, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add links to github repo and issues on bot homepage
2 participants