Feature/digitalocean spaces #1706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 23, 2020 17:23
…onataMediaBundle into feature/digitalocean_spaces
OskarStark
reviewed
Feb 24, 2020
| ->replaceArgument(2, ['create' => $config['filesystem']['spaces']['create'], 'region' => $config['filesystem']['spaces']['region'], 'directory' => $config['filesystem']['spaces']['directory'], 'ACL' => $config['filesystem']['spaces']['acl']]) | ||
| ; | ||
|
|
||
| $container->getDefinition('sonata.media.metadata.amazon') |
There was a problem hiding this comment.
from what i understand DO Spaces is s3-compliant. However, that is a good question if we need it at all. It may be required by Gaufrette AwsS3 adaptor.
core23
reviewed
Mar 15, 2020
| @@ -251,6 +251,50 @@ private function addFilesystemSection(ArrayNodeDefinition $node): void | |||
| ->end() | |||
| ->end() | |||
|
|
|||
| ->arrayNode('spaces') | |||
There was a problem hiding this comment.
Can you please try to extract some small methods. This will improve readability.
|
Can you please finish this @jessequinn ? |
|
I was able to use Sonata Media with DigitalOcean Spaces using this approach #1774 and the sonata s3 configuration, so I think this change is not needed. |
|
This one should not be necessary anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Allows for DigitalOcean Spaces to be used based on S3.
I am targeting this branch, because it is current.
I believe this addresses no issues at the moment other than the need for Spaces integration. Based on S3 filesystem. If new adaptor is made, currently in backlog, it will be easily integrated.
Changelog
Added
Added DigitalOcean Spaces support