-
-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
endpoint configuration for s3 storage #1774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please provide a test, so we don't get unexpected exceptions when not defining the key
Ok, I made some changes. Is it fine to update the existing test with this new key? |
Yes please, update the tests and add a new one to test what happens when this new key is configured |
Plus it would be nice to update docs with that addition |
The updated test should cover both situations or am I missing something? |
@@ -399,6 +399,10 @@ public function configureFilesystemAdapter(ContainerBuilder $container, array $c | |||
'version' => $config['filesystem']['s3']['version'], | |||
]; | |||
|
|||
if (isset($config['filesystem']['s3']['endpoint'])) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an other test that does not modify the endpoint and skips this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this one already skipping this line? https://github.com/sonata-project/SonataMediaBundle/pull/1774/files#diff-217ffd8f1233ee89cb0db792bd11981dL220-L236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash your commits into 1
Please review @core23 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still a test missing that is checking for a null
endpoint value, but I don't want to block this PR.
Thank you @michalpicpauer |
Subject
Add endpoint configuration option for s3 filesystem.
I am targeting this branch, because these changes respect BC.
Closes #1773 #1706
Changelog