Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jbang dependency option #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxandersen
Copy link

(brief, plain english overview of your changes here)

This pull request makes the following changes:

  • add a jbang dependency info section similar to gradle, bazel, etc.

@sonatypecla
Copy link

sonatypecla bot commented Nov 21, 2020

Thanks for the contribution! Before we can merge this, we need @maxandersen to sign the Sonatype Contributor License Agreement.

@maxandersen
Copy link
Author

I've signed the CLA:

2020-11-21_02-29-12

Anything else needed ?

@DarthHater
Copy link
Member

Hiya @maxandersen ! We work on this repo about once every two weeks unless it's an emergency, sorry for the wait.

I don't see an issue with merging this, gonna tag @SirMaster in case he has any objections!

Copy link
Contributor

@SirMaster SirMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

Thanks @maxandersen

@maxandersen
Copy link
Author

Awesome :) thanks!

@maxandersen
Copy link
Author

Any eta for when this will be live ? Thanks again.

@vlsi
Copy link

vlsi commented Oct 21, 2021

This adds clutter, and adding more and more obscure templates does not scale. Can the templating be customizable, so the users could add their preffered formatting?

@DarthHater
Copy link
Member

@maxandersen I need to import it and merge it more or less. I'll do that soon!

@vlsi , an alternative approach would be to limit the amount of Java build tools (just playing :) )

We HAVE added a ton of clutter, it's totally true. Internally we have been using React for a lot more projects, and search.maven.org is kind of hanging out in Angular land. I think in the nearish future, if I can get the time and some people on board I'd like to rewrite it in React and then address some of these UX/UI type issues. If you'd want to collaborate that would be cool!

@vlsi
Copy link

vlsi commented Oct 22, 2021

@DarthHater , I'm a designer as in "I'm a programmer so I can fix a printer" :) I can read and write React code with a dictionary, however, if I setup a react project, it would likely be very very far from idiomatic react apps :)

@maxandersen
Copy link
Author

Making the tabs a combo would help significantly

@aghasemi
Copy link

aghasemi commented Mar 1, 2022

Hi. May I ask if there is an update on this? I will happily vote in any priority list if that matters :)

@gastaldi
Copy link

I am really looking forward to seeing this live. What's missing to get it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants