-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add jbang dependency option #137
base: master
Are you sure you want to change the base?
Conversation
Thanks for the contribution! Before we can merge this, we need @maxandersen to sign the Sonatype Contributor License Agreement. |
Hiya @maxandersen ! We work on this repo about once every two weeks unless it's an emergency, sorry for the wait. I don't see an issue with merging this, gonna tag @SirMaster in case he has any objections! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
Thanks @maxandersen
Awesome :) thanks! |
Any eta for when this will be live ? Thanks again. |
This adds clutter, and adding more and more obscure templates does not scale. Can the templating be customizable, so the users could add their preffered formatting? |
@maxandersen I need to import it and merge it more or less. I'll do that soon! @vlsi , an alternative approach would be to limit the amount of Java build tools (just playing :) ) We HAVE added a ton of clutter, it's totally true. Internally we have been using React for a lot more projects, and search.maven.org is kind of hanging out in Angular land. I think in the nearish future, if I can get the time and some people on board I'd like to rewrite it in React and then address some of these UX/UI type issues. If you'd want to collaborate that would be cool! |
@DarthHater , I'm a designer as in "I'm a programmer so I can fix a printer" :) I can read and write React code with a dictionary, however, if I setup a react project, it would likely be very very far from idiomatic react apps :) |
Making the tabs a combo would help significantly |
Hi. May I ask if there is an update on this? I will happily vote in any priority list if that matters :) |
I am really looking forward to seeing this live. What's missing to get it merged? |
(brief, plain english overview of your changes here)
This pull request makes the following changes: