Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PIT HLD document , this PR replace previous PR#1014. #1127

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

clarklee-guizhao
Copy link
Collaborator

@clarklee-guizhao clarklee-guizhao commented Nov 23, 2022

Replace previous PR#1014, #1014.

  • Add clarification for platform plugins, add plan for supporting platform APIs.
  • Fix some typo.
  • Change branch name to master.
Repo PR title State
sonic-buildimage [sonic-pit] Add PIT(Platform Integration Test) feature, first commit with only framework and 2 test cases with 1 supportting platform. GitHub issue/pull request detail
sonic-buildimage [sonic-pit]Add PIT(Platform Integration Test) feature, second part, add 6 test cases. GitHub issue/pull request detail

@clarklee-guizhao
Copy link
Collaborator Author

Replace previous PR#1014, #1014.

  • Add clarification for platform plugins, add plan for supporting platform APIs.
  • Fix some typo.
  • Change branch name to master.

Repo PR title State
sonic-buildimage [sonic-pit] Add PIT(Platform Integration Test) feature, first commit with only framework and 2 test cases with 1 supportting platform. GitHub issue/pull request detail
sonic-buildimage [sonic-pit]Add PIT(Platform Integration Test) feature, second part, add 6 test cases. GitHub issue/pull request detail

@zhangyanzhao @lihuay @keboliu
Hi folks, I redo this HLD PR to replace previous #1014 PR, please help review this PR for PIT, thanks a lot.

@clarklee-guizhao
Copy link
Collaborator Author

Also, please add @jeff-yin and @prgeor as reviews as PR#1014 :)

@zhangyanzhao
Copy link
Collaborator

@StormLiangMS this feature need be back ported to 202211

lihuay
lihuay previously approved these changes Nov 24, 2022
@zhangyanzhao
Copy link
Collaborator

@clarklee-guizhao can you please sign the EasyCLA? That is required before the PR can be merged. Also can you please address Jeff's comments? Thanks.

@zhangyanzhao
Copy link
Collaborator

@jeff-yin @lihuay can you please check this PR to see if you are ok to approve and merge? Thanks.

jeff-yin
jeff-yin previously approved these changes Feb 28, 2023
Copy link

@jeff-yin jeff-yin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about something minor to double check. Otherwise LGTM.

Signed-off-by: Li Hua <guizhao.lh@alibaba-inc.com>
… HLD.

Signed-off-by: Li Hua <guizhao.lh@alibaba-inc.com>
Signed-off-by: Li Hua <guizhao.lh@alibaba-inc.com>
@zhangyanzhao
Copy link
Collaborator

added to 202305 release plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: MovedToBacklog
Development

Successfully merging this pull request may close these issues.

6 participants