Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xcvrd] typo "log_notifce" results in port oper down #19116

Closed
Junchao-Mellanox opened this issue May 29, 2024 · 1 comment
Closed

[xcvrd] typo "log_notifce" results in port oper down #19116

Junchao-Mellanox opened this issue May 29, 2024 · 1 comment
Assignees
Labels
Triaged this issue has been triaged

Comments

@Junchao-Mellanox
Copy link
Collaborator

Description

PR sonic-net/sonic-platform-daemons#459 introduces a typo "log_notifce". Check line: https://github.com/sonic-net/sonic-platform-daemons/blob/9ffce2036d53571bd23b4a630ac285039e383c4f/sonic-xcvrd/xcvrd/xcvrd.py#L1482.

It causes an exception in cmis task manager which results in port down:

May 27 20:38:17.489639 sonic ERR pmon#xcvrd: CMIS: Ethernet96: internal errors due to 'CmisManagerTask' object has no attribute 'log_notifce'

Steps to reproduce the issue:

no need

Describe the results you received:

typo and port not up

Describe the results you expected:

No typo and port should up

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@prgeor prgeor self-assigned this May 29, 2024
@prgeor prgeor added the Triaged this issue has been triaged label May 29, 2024
mssonicbld added a commit that referenced this issue Jun 1, 2024
…D automatically (#19165)

#### Why I did it
src/sonic-platform-daemons
```
* 5bb903c - (HEAD -> 202311, origin/202311) Fix for #19116 [xcvrd] typo "log_notifce" results in port oper down (#493) (62 minutes ago) [Anoop Kamath]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this issue Jun 4, 2024
…D automatically (#19130)

#### Why I did it
src/sonic-platform-daemons
```
* 76cf1dc - (HEAD -> master, origin/master, origin/HEAD) Fix for #19116 [xcvrd] typo "log_notifce" results in port oper down (#493) (4 days ago) [Anoop Kamath]
* f41ecca - Implementation of a Monitoring Daemon for storage devices in SONiC switches (#433) (4 days ago) [Ashwin Srinivasan]
* 28302d4 - Update for the procedures for insertion/hot swap of Switch Fabric Module (SFM) by using "config chassis modules shutdown/startup" commands (#491) (5 days ago) [JunhongMao]
```
#### How I did it
#### How to verify it
#### Description for the changelog
@arlakshm
Copy link
Contributor

arlakshm commented Jun 5, 2024

This issue is fixed. Closing it

@arlakshm arlakshm closed this as completed Jun 5, 2024
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this issue Jul 26, 2024
…D automatically (sonic-net#19130)

#### Why I did it
src/sonic-platform-daemons
```
* 76cf1dc - (HEAD -> master, origin/master, origin/HEAD) Fix for sonic-net#19116 [xcvrd] typo "log_notifce" results in port oper down (sonic-net#493) (4 days ago) [Anoop Kamath]
* f41ecca - Implementation of a Monitoring Daemon for storage devices in SONiC switches (sonic-net#433) (4 days ago) [Ashwin Srinivasan]
* 28302d4 - Update for the procedures for insertion/hot swap of Switch Fabric Module (SFM) by using "config chassis modules shutdown/startup" commands (sonic-net#491) (5 days ago) [JunhongMao]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triaged this issue has been triaged
Projects
None yet
Development

No branches or pull requests

3 participants