-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Arista 7260 -- modified ID of ff:0b.3 in YAML file #15899
Conversation
@assrinivasan can you paste the output of setpci PCI vendor ID for the PCI device in question(in PR description)? |
@Staphylo @andywongarista could you please review this change? |
Done. |
I got similar error with newest image on Arista 720DT:
|
Hi, this is a regression introduced by a change in Looking at the commit history on On top of some obvious issues in the code (leftover The real issue here is the complete bypass of the PcieUtil introduced by the PR above. For our platforms we implement our own PcieUtil class and ignore the yaml file entirely. The reason we implement PcieUtil and not a static yaml file is to gracefully handle hotswap hardware. @Blueve why is |
/easycla |
@Staphylo I did not understand this. Can you elaborate? Why would kernel see a different device ID ?
|
@assrinivasan this is still causing many failures in nightly, could you work with reviewer to resolve the PR? |
@assrinivasan yes you can remove this device from the pcie.yaml file. |
Why I did it
The Arista 7260 has a PCI peripheral at address ff:0b.3 whose ID is set as '0001' in the pcie.yaml file but presents as '6f76' on the actual device. This causes a device mismatch error on the pcie daemon and subsequent syslog flooding with the same error.
Work item tracking
How I did it
Modified ID field of ff:0b.3 in the corresponding pcie YAML file
How to verify it
Install latest image after the merge and verify that syslogs are not flooded with PCI device mismatch errors
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)