-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add static route #1848
Open
tientienle
wants to merge
1
commit into
sonic-net:master
Choose a base branch
from
tientienle:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add static route #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can anyone please review on the failure? |
retest this please |
I'm now working on this, this is my schema: {
|
5 tasks
lguohan
pushed a commit
that referenced
this pull request
Aug 25, 2021
d29a49a [ACL] Match TCP protocol while matching TCP_FLAG (#1854) 2569ad9 Fix sFlow sampling-rate and admin-state (#1728) 8908a8f Change rif_rates.lua and port_rates.lua scripts to calculate rates correct (#1848) b42c2fb [VS Test] Skip flaky tests (#1875) Signed-off-by: bingwang <bingwang@microsoft.com>
judyjoseph
added a commit
that referenced
this pull request
Aug 26, 2021
88a38f7 Ignore ALREADY_EXIST error in FDB creation (#1815) b1c23f3 Change rif_rates.lua and port_rates.lua scripts to calculate rates correct (#1848) Update sonic-utilities submodule with cbc25d6 [config reload] Call systemctl reset-failed for snmp,telemetry,mgmt-framework services (#1773) 04dcd07 Improve config error handling on version_info (#1760) e567a60 Load the database global_db. (#1752) c15fb8f [sfputil] Gracefully handle improper 'specification_compliance' field (#1741) 39350f8 [dhcp_relay] Update CLI reference document and add a new API for ip address type (#1717) 18f13c6 [sonic-package-manager] switch from poetry-semver to semantic_version due to bugs found in poetry-semver (#1710) b16724a [voq][chassis] VOQ cli show commands implementation (#1689) 9427cd6 [debug dump util] Match Infrastructure (#1666) d9fb39b [route_check] Filter out VNET routes (#1612)
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Oct 2, 2021
* 647f01f 2021-09-30 | [fstrim] limit smartctl execution time to 30 seconds (sonic-net#1850) (HEAD -> 202012, github/202012) [Ying Xie] * 371970e 2021-09-30 | [202012][show techsupport] address show techsupport return none zero code issue (sonic-net#1847) [Ying Xie] * 81a8386 2021-09-30 | Disable pfcwd forward action config for cisco-8000. (sonic-net#1848) [Alpesh Patel] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Oct 4, 2021
* 647f01f 2021-09-30 | [fstrim] limit smartctl execution time to 30 seconds (#1850) (HEAD -> 202012, github/202012) [Ying Xie] * 371970e 2021-09-30 | [202012][show techsupport] address show techsupport return none zero code issue (#1847) [Ying Xie] * 81a8386 2021-09-30 | Disable pfcwd forward action config for cisco-8000. (#1848) [Alpesh Patel] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
…rrect (sonic-net#1848) Change rif_rates.lua and port_rates.lua scripts to calculate rates properly - rates_table_names table should be updated after each iteration and not only once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that sonic does not have anywhere to save the static route. However I think this is a fundamental function for a router or switch. Every time I reboot or reload the switch, I need to add the static route again,
- What I did
- How I did it
- How to verify it
"ROUTE_TABLE": {
"1.1.1.0/24|192.168.111.2": {
"ad": "1"
},
"1.1.1.0/24|192.168.111.3": {
"ad": "2"
},
"2.3.4.0/24|192.168.111.1": {
"ad": "1"
}
},