Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[caclmgrd] Allow more ICMP types #4625

Merged
merged 1 commit into from
May 21, 2020
Merged

[caclmgrd] Allow more ICMP types #4625

merged 1 commit into from
May 21, 2020

Conversation

jleveque
Copy link
Contributor

Allow two more ICMP/ICMPv6 packet types which allow traceroute to work properly:

  • destination-unreachable
  • time-exceeded

@jleveque jleveque requested a review from lguohan May 20, 2020 21:33
@jleveque jleveque self-assigned this May 20, 2020
@jleveque jleveque merged commit bce42a7 into sonic-net:master May 21, 2020
@jleveque jleveque deleted the cacl_add_more_icmp branch May 21, 2020 00:45
abdosi pushed a commit that referenced this pull request Jun 3, 2020
@jleveque @abdosi
[caclmgrd] Allow more ICMP types (#4625)
f2c0ed8
yxieca pushed a commit that referenced this pull request Jun 9, 2020
@jleveque @yxieca
[caclmgrd] Allow more ICMP types (#4625)
494701a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees

@jleveque jleveque

Labels
Control Plane ACL Enhancement ➕ Included in 201811 Branch Included in 201911 Branch Request for 201811 Branch :shipit: Request for 201911 Branch :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jleveque @lguohan @yxieca @abdosi