[oneimage] Update dhclient.conf #479

taoyl-ms · 2017-04-04T22:14:00Z

Add request to option 226 back, and uses also request instead of request.

It turns out that certain dhcp server implementation (dnsmasq) will fail to send option 82 correctly under certain situation, and will lead to DHCP relay fail to forward the packet. Using "also request" instead of "request" happens to help us getting out of bugging situation of dnsmasq.

taoyl-ms · 2017-04-04T22:45:33Z

More information that might be useful -
The Parameter-Request (option 55) value of DHCP request packages before and after this commit:

Before
Parameter-Request Option 55, length 16:
Subnet-Mask, BR, Time-Zone, Default-Gateway
Domain-Name, Domain-Name-Server, Option 119, Hostname
Netbios-Name-Server, Netbios-Scope, MTU, Classless-Static-Route
NTP, Option 224, Option 225, Option 226

After:
Parameter-Request Option 55, length 23:
Subnet-Mask, BR, Time-Zone, Default-Gateway
Domain-Name, Domain-Name-Server, Hostname, Subnet-Mask
BR, Time-Zone, Default-Gateway, Domain-Name
Domain-Name-Server, Option 119, Hostname, Netbios-Name-Server
Netbios-Scope, MTU, Classless-Static-Route, NTP
Option 224, Option 225, Option 226

taoyl-ms · 2017-04-04T22:47:58Z

By sending default options (Subnet-Mask, BR, Time-Zone, Default-Gateway
Domain-Name, Domain-Name-Server, Hostname) twice we were able to avoid the bugging circumstance in dnsmasq.

lguohan · 2017-04-05T18:06:42Z

retest this please

lguohan · 2017-04-05T18:16:32Z

not sure if this is the right way to do it, sending default options twice in the request does not seem to be the right way to fix the problem.

It seems the root cause this the dnsmasq, then we should fix on that side instead of sonic.

lguohan

does not like to be the right way to address the issue.

taoyl-ms · 2017-04-05T18:19:40Z

I am pretty sure it is a dnsmasq issue, and is happening only when length of option 55 equals to 16. I'll try to upgrade the dnsmasq version first to see if the issue remains there.

taoyl-ms · 2017-04-05T19:50:08Z

After discussion, we switch back to "request" so that we are not sending duplicated requests, but instead we remove several options that are not being used to avoid option length being 16.

lguohan · 2017-04-05T20:04:18Z

files/dhcp/dhclient.conf

-        dhcp6.name-servers, dhcp6.domain-search,
-        netbios-name-servers, netbios-scope, interface-mtu,
-        rfc3442-classless-static-routes, ntp-servers, snmp-community, minigraph-url;
+        dhcp6.name-servers, dhcp6.domain-search, interface-mtu,


you also removed option 119?

No I didn't. I'm not exactly sure which of these dhclient option names maps to option 119.

For information, the current value of option 55 in DHCPRequest is:
Parameter-Request Option 55, length 14:
Subnet-Mask, BR, Time-Zone, Default-Gateway
Domain-Name, Domain-Name-Server, Option 119, Hostname
MTU, Classless-Static-Route, NTP, Option 224
Option 225, Option 226

* ea34b92 2018-04-24 | Fix tables handling race condition in buffermgr (#484) (HEAD -> 201803, origin/201803) [Andriy Moroz] * 53831be 2018-04-19 | [pfcwd]: create PFCWD acl instead of L3 ACL (#479) [sihuihan88] Signed-off-by: Guohan Lu <gulv@microsoft.com>

[installer]: Suppress tar xz warning about time stamp in the future, if date is not correctly set (sonic-net#1562) \[sonic-platform-common\] Update submodule (sonic-net#1563) \- Includes the following commits: \- \[bcmshell.py\] Match extra whitespace before prompt in regex (#3) \- add support for qsfp28 eeprom (#2) \[baseimage\]: bring down eth0 before restart networking (sonic-net#1555) cfggen generates new eth0 configuration. Need to first clean existing configuration on eth0 before bring up new configuration on eth0. Thus, we need to first bring down eth0 before putting new configuration into /etc/network/ interfaces \[mellanox\]: Update MLNX SAI pointer (sonic-net#1557) \[minigraph.py\] Add support to parse tacacs server information (sonic-net#1549) \* \[minigraph.py\] Add support to parse tacacs server information \[router advertiser\] Only start radvd process if device role is 'ToRRouter' (sonic-net#1569) \[submodules\]: update sonic-swss (sonic-net#1570) \[submodules\]: update sonic-utilities (sonic-net#1571) \[cfggen\]: ignore acl when its type is not defined (sonic-net#1568) \[installer\]: Umount before delete partition (sonic-net#1575) Use eth0 interface only to generate lldpd SystemId (sonic-net#1577) Allow one Service ACL to bind to multiple services (sonic-net#1576) \* \[caclmgrd\] Also ignore IP protocol if found in rule; we will only use our predefined protocols \[snmp\]: Bind snmpd to all ip addresses (sonic-net#1587) \[device\] Update Arista driver submodule (sonic-net#1585) Watchdog timeout increased \[devices\]: Fix type for qos.json in 7060 and S6100 (sonic-net#1582) \[minigraph\]: ignore minigraph ports which are not in port_config.ini (sonic-net#1593) \[minigraph\] Fix parser on PNG DeviceInterfaceLink Bandwidth (sonic-net#1592) \* \[minigraph\] Fix parser on PNG DeviceInterfaceLink Bandwidth \[Broadcom SAI\] upgrade Broadcom SAI to version 3.1.3.4-10 (sonic-net#1591) \* \[Broadcom SAI\] upgrade Broadcom SAI to version 3.1.3.4-9 Includes configuration files for following devices: \- Quanta 1X1B-32X \- Dell Z9264F \- Inventec D7054Q28B and D7032Q28B \* \[bcm sai\] upgrade sai version to 3.1.3.4-10 include configuration change to 7060 T0. 50G support for Arista 7060 (sonic-net#1580) \* 50G SKU for Arista 7060 Marvell's updates for SONiC 201803 over SAI v1.2 (sonic-net#1588) \[Mellanox\] Add support for a new platform LS-SN2700 \[devices\]: Merge ingress service pools of lossless and lossy traffic for TD2 (sonic-net#1578) \[sonic-utilities\] add pfcstat and queuestat tool (sonic-net#1606) Add support for S6100 switchport LEDs (sonic-net#1610) \[ip-in-ip\]: Fix config template to apply correct platform depended values (sonic-net#1619) \[platform-common\]: Update sonic-platform-common submodule (sonic-net#1620) \[sfputilbase\]: Add logic to parse the title of port_config.ini file \[sonic-cfggen\] Be case insensitive to hostname in minigraph (sonic-net#1614) \[bugfix\]: pass correct port name to led_control.py in ledd \[cfggen\]: Fix build by fixing pyangbind version (sonic-net#1633) \[swss\]: update sonic-swss submodule \* ea34b92 2018-04-24 | Fix tables handling race condition in buffermgr (sonic-net#484) (HEAD -> 201803, origin/201803) \[Andriy Moroz\] \* 53831be 2018-04-19 | \[pfcwd\]: create PFCWD acl instead of L3 ACL (sonic-net#479) \[sihuihan88\] \[radvd\] Ensure at least one interface is specified in radvd.conf before starting radvd (sonic-net#1636) \[updategraph\]: Keep updategraph service active after start (sonic-net#1651) \[docker-lldpd\]: Various fixes (sonic-net#1650) \* We don't need configure anything until we have interfaces created \* Don't run lldpcli for a port, until a port is up and running \* Remove lldpd socket before starting lldpd \* Fix sample files for lldpd configuration \* Another attempt to make the test working \* Quick fix for lldpd paused after start bug \[submodules\]: update swss and utilities modules swss: \* e34104e 2018-04-13 | \[pfcwd\]: support BIG_RED_SWITCH mode (sonic-net#467) (HEAD, origin/201803) \[sihuihan88\] \* 1f857d5 2018-04-25 | \[buffermgr\]: remove the item from consumer queue if invalid (sonic-net#489) \[sihuihan88\] utilities: \* 0b9bb2b 2018-04-26 | Stop services before pushing new config during "load_minigraph" (sonic-net#247) (HEAD, origin/201803) \[Prince Sunny\] \* dc119c9 2018-04-18 | \[show logging\] For following, change 'tail -f' to 'tail -F' in order to retry in the case log is rotated (sonic-net#240) \[Joe LeVeque\] \* 08da428 2018-04-16 | \[pfcwd\]: add cli to enable/disable BIG_RED_SWITCH mode (sonic-net#237) \[sihuihan88\] \[snmp\]: Fix a race between snmpd-config-updater and snmpd (sonic-net#1628) There is a small window in which snmpd might not have registered a callback for SIGHUP and which will result in its death if snmpd-config-updater send this signal meant for a config reload. \[snmpd\]: Fix typo in is_platform_arista (sonic-net#1634) \[mellanox\]: Update SAI version to 1.11.4 and SDK to 4.2.7303 (sonic-net#1655) \[docker-dhcp\]: Fix the sonic build issue (sonic-net#1659) Install the built version of isc-dhcp-client in docker-dhcp-relay \[swss\]: update swss 118b3f0 2018-05-01 | Populate existing interface cache, bring down before configDone \[zebra.conf\] Fix template issue with multiple lo addresses (sonic-net#1662) \* \[zebra.conf\] Fix template issue with multiple lo addresses \* Add unitest for Loopback1 \[swss\]: Change the hash seed to 0 for ToR and 10 for Leaf routers (sonic-net#1667) Due to some ASIC platform limitations, the hash seed range is from 0 to 15. Thus the switch.json.j2 template is updated so that ToRRouter is using hash seed 0 and LeafRouter is using hash seed 10. \[snmp\]: Stop spamming logs with statfs permission denied log message (sonic-net#1668) \[broadcom\]: update broadcom SAI to 3.1.3.4-11 (sonic-net#1670) Provide better ECMP load-balancing via hash seed \[sonic-cfggen\]: fix bgpd and zebra template for sonic-cfggen test I took the original patch (bebb7a0) into 201803 branch need to also adapt the patch since we do not have commit (d423841) in 201803 branch. \[swss\]: update sonic-swss module \[201803 d57f9a1\] \[lua\]: use not to check whether the field exists (sonic-net#492) \[device\] Update arista driver submodule (sonic-net#1674) \[submodule\]: Update submodule sonic-snmpagent (sonic-net#1642) sonic-cfggen supports hwsku parameter (sonic-net#1631) \*Note\*: tuned test data during cherry-pick \[device\] Add PSU utility for platform ly1200 of MiTAC (sonic-net#1673) \[platform/broadcom/sonic-platform-modules-mitac\] Install acpi package for daemon and adjust i2c sequence \[mellanox\]: Update MLNX SAI pointer (sonic-net#1684) 40G profile for Arista 7060 (sonic-net#1677) Update buffers config for Mellanox 27xx devices (sonic-net#1649) \* Update buffers config for Mellanox 27xx devices \* Remove buffers template test for msn27xx \[submodule\]: Update submodule sonic-snmpagent: Improve mib fundamental classes (sonic-net#1689) \[sonic-utilities\]: update sonic utilities submodule \* 951633b 2018-05-04 | \[generate_dump\]: fix a saidump file copy bug (sonic-net#248) (HEAD, origin/201803) \[Kebo Liu\] \* 69baff7 2018-05-03 | \[acl_loader\]: Missing one colon (sonic-net#252) \[Shuotian Cheng\] \* 557248d 2018-05-02 | \[acl-loader\]: Add --table_name option to update full operation (sonic-net#249) \[Shuotian Cheng\] \* a8aadee 2018-04-30 | \[acl-loader\]: Change the header from Rule ID to Table (sonic-net#250) \[Shuotian Cheng\] \[swss\]: update sonic-swss \* b57c376 2018-05-10 | \[teamsyncd\]: Add team_ifindex2ifname return value check (sonic-net#500) (HEAD, origin/201803) \[Shuotian Cheng\] \* 236843f 2018-05-07 | Fix Crm Acl used counter update (sonic-net#496) \[Nadiya\] \[swss\]: update sonic-swss c374357 2018-04-23 | Fix ZeroBufferProfile parameters (sonic-net#485) (HEAD -> 201803) \[Andriy Moroz\] \[platform\]: Fixed Cavium platform modules build. (sonic-net#1694) \[submodule\]: Update submodule sonic-snmpagent: Improve mib fundamental classes: retry after reinit_data() throws (sonic-net#1700) Merge branch 'github-1803' Conflicts: dockers/docker-router-advertiser/start.sh platform/broadcom/sai.mk platform/mellanox/mlnx-sai.mk src/sonic-config-engine/sonic-cfggen src/sonic-config-engine/tests/sample_output/ports.json src/sonic-config-engine/tests/test_cfggen.py src/sonic-platform-daemons src/sonic-snmpagent src/sonic-swss src/sonic-utilities \[baseimage\]: Disable DAD for eth0 explicitly (sonic-net#1701) \[quagga\]: update quagga submodule (sonic-net#1698) \* \[quagga\]: update quagga submodule 0bc6bd6 2018-05-11 | ignore nexthop attribute when NLRI is present (#18) (HEAD, origin/debian/0.99.24.1, origin/HEAD) \[lguohan\] \* add vs bgp test Fix the build error Revert "\[sonic-cfggen\]: fix bgpd and zebra template for sonic-cfggen test" This reverts commit b29d835. Fix the build issue for sonic-cfggen test Merge branch 'github-1803' --5/12 Conflicts: src/sonic-quagga src/sonic-snmpagent RB=1312391 G=lnos-reviewers R=pchaudha,pmao,rmolina,zxu A=

Signed-off-by: Sihui Han <sihan@microsoft.com>

Includes commits ``` f3e1085 2021-04-22 | [swig] fix ConfigDBConnector.db_name (#483) [Qi Luo] 0e2f1c0 2021-04-21 | [swig] Implement SonicV2Connector.hmset() (#480) [Qi Luo] d18ce28 2021-04-21 | [swss-common] Add MUX Metrics Table (#482) [Tamer Ahmed] 2e5a194 2021-04-20 | Support for in-band-mgmt via management VRF (#479) [Venkatesan Mahalingam] 3e5529f 2021-04-19 | [swig] Implement TableEntryPoppable.pops() (#478) [Qi Luo] 4a3903b 2021-04-19 | Support for in-band-mgmt via management VRF. (#476) [Venkatesan Mahalingam] fc2c734 2021-04-19 | [swig] allow threads (#477) [Qi Luo] ```

Includes commits ``` f3e1085 2021-04-22 | [swig] fix ConfigDBConnector.db_name (sonic-net#483) [Qi Luo] 0e2f1c0 2021-04-21 | [swig] Implement SonicV2Connector.hmset() (sonic-net#480) [Qi Luo] d18ce28 2021-04-21 | [swss-common] Add MUX Metrics Table (sonic-net#482) [Tamer Ahmed] 2e5a194 2021-04-20 | Support for in-band-mgmt via management VRF (sonic-net#479) [Venkatesan Mahalingam] 3e5529f 2021-04-19 | [swig] Implement TableEntryPoppable.pops() (sonic-net#478) [Qi Luo] 4a3903b 2021-04-19 | Support for in-band-mgmt via management VRF. (sonic-net#476) [Venkatesan Mahalingam] fc2c734 2021-04-19 | [swig] allow threads (sonic-net#477) [Qi Luo] ```

[oneimage] Update dhclient.conf

c316ff0

taoyl-ms requested a review from lguohan April 4, 2017 22:14

lguohan reviewed Apr 5, 2017

View reviewed changes

Update dhclient.conf

6a9556e

lguohan reviewed Apr 5, 2017

View reviewed changes

lguohan approved these changes Apr 5, 2017

View reviewed changes

taoyl-ms merged commit b0537ea into master Apr 5, 2017

taoyl-ms deleted the taoyl/patch-2 branch April 20, 2017 22:10

madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020

[pfcwd]: create PFCWD acl instead of L3 ACL (sonic-net#479)

84ce5ed

Signed-off-by: Sihui Han <sihan@microsoft.com>

madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020

[pfcwd]: create PFCWD acl instead of L3 ACL (sonic-net#479)

53831be

Signed-off-by: Sihui Han <sihan@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[oneimage] Update dhclient.conf #479

[oneimage] Update dhclient.conf #479

taoyl-ms commented Apr 4, 2017 •

edited

Loading

taoyl-ms commented Apr 4, 2017 •

edited

Loading

taoyl-ms commented Apr 4, 2017

lguohan commented Apr 5, 2017

lguohan commented Apr 5, 2017

lguohan left a comment

taoyl-ms commented Apr 5, 2017

taoyl-ms commented Apr 5, 2017 •

edited

Loading

lguohan Apr 5, 2017

taoyl-ms Apr 5, 2017

taoyl-ms Apr 5, 2017

[oneimage] Update dhclient.conf #479

[oneimage] Update dhclient.conf #479

Conversation

taoyl-ms commented Apr 4, 2017 • edited Loading

taoyl-ms commented Apr 4, 2017 • edited Loading

taoyl-ms commented Apr 4, 2017

lguohan commented Apr 5, 2017

lguohan commented Apr 5, 2017

lguohan left a comment

Choose a reason for hiding this comment

taoyl-ms commented Apr 5, 2017

taoyl-ms commented Apr 5, 2017 • edited Loading

lguohan Apr 5, 2017

Choose a reason for hiding this comment

taoyl-ms Apr 5, 2017

Choose a reason for hiding this comment

taoyl-ms Apr 5, 2017

Choose a reason for hiding this comment

taoyl-ms commented Apr 4, 2017 •

edited

Loading

taoyl-ms commented Apr 4, 2017 •

edited

Loading

taoyl-ms commented Apr 5, 2017 •

edited

Loading