[aboot]: add varlog limit file in aboot image #487

lguohan · 2017-04-07T08:08:20Z

No description provided.

lguohan · 2017-04-07T16:39:01Z

@qiluo-msft, can you review? #Closed

qiluo-msft · 2017-04-07T17:42:00Z

files/initramfs-tools/arista-convertfs.j2

@@ -82,6 +82,24 @@ run_cmd() {
    fi
 }

+create_varlog_file() {


create_varlog_file [](start = 0, length = 18)

This function is not Arista specific. Suggest to move to a new file or into union-mount. #Closed

for onie installer, it is in the installation process. For arista, since it does not have installation process, is needs to be put here.

I think the varlog filesystem should be created in the installation process. For arista platform, I am also asking them to push these operations into their installation process (they are coming up with some solution there). Thus, moving to union-mount does not look like to be long term solution. #Closed

the reason I think it should be in the installation process is to save the boot time. #Closed

I see. This function is Arista specific because in the process of Arista aboot installation, there is no tool to create an ext4 partition, and it must be postpone to initramfs. #Closed

qiluo-msft · 2017-04-07T17:43:03Z

files/Aboot/boot0.j2

@@ -102,6 +101,7 @@ platform_specific() {
    if [ "$platform" = "raven" ]; then
        aboot_machine=arista_7050_qx32
        echo "modprobe.blacklist=radeon" >>/tmp/append
+        echo "varlog_size=100" >>/tmp/append


100 [](start = 26, length = 3)

I guess the unit is 'MB'. Could you add some comment? #Closed

qiluo-msft · 2017-04-07T17:43:45Z

files/initramfs-tools/arista-convertfs.j2

+
+err_msg="Error: create var-log ext4 file"
+cmd="[ -n $varlog_size ] && mkdir -p $root_mnt/disk-img && dd if=/dev/zero of=$root_mnt/disk-img/var-log.ext4 count=$((2048*$varlog_size)) && mke2fs -t ext4 -q -F $root_mnt/disk-img/var-log.ext4"
+run_cmd "$cmd" "$err_msg"


It could be merge into create_varlog_file(). #Closed

qiluo-msft

As comments.

qiluo-msft · 2017-04-07T18:14:25Z

files/initramfs-tools/arista-convertfs.j2


+blkid | grep "$root_dev.*vfat" -q || create_varlog_file


create_varlog_file [](start = 37, length = 18)

explicitly call 'exit' after create_varlog_file, to prevent any future mistake. #Closed

create varlo_file has the exit inside.

I know the code is working. We can still make the code more readable and less error prone. I am ok with alternative of strong warning comments here and above the function. #Closed

* 1b734f1 2019-03-22 | use pytest in setuptools (sonic-net#490) [lguohan] * 7030c97 2019-03-21 | [show] show interface status added vlan and portchannels to command (sonic-net#483) [Travis Van Duyn] * a30d1a8 2019-03-21 | [warm/fast reboot] setup control plane assistant when available (sonic-net#487) [Ying Xie] * 8182dfa 2019-03-21 | [reboot script] add -h, -? options (sonic-net#484) [Ying Xie] Signed-off-by: Guohan Lu <gulv@microsoft.com>

Submodule src/sonic-utilities 2fe01fe..9d9aaa0: > [warm/fast reboot] setup control plane assistant when available (sonic-net#487) > [reboot script] add -h, -? options (sonic-net#484) Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Submodule src/sonic-utilities 2fe01fe..9d9aaa0: > [warm/fast reboot] setup control plane assistant when available (#487) > [reboot script] add -h, -? options (#484) Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* [sonic-utilities]: fix sonic-utilities build error * 1b734f1 2019-03-22 | use pytest in setuptools (#490) [lguohan] * 7030c97 2019-03-21 | [show] show interface status added vlan and portchannels to command (#483) [Travis Van Duyn] * a30d1a8 2019-03-21 | [warm/fast reboot] setup control plane assistant when available (#487) [Ying Xie] * 8182dfa 2019-03-21 | [reboot script] add -h, -? options (#484) [Ying Xie] Signed-off-by: Guohan Lu <gulv@microsoft.com>

Submodule src/sonic-utilities 2fe01fe..9d9aaa0: > [warm/fast reboot] setup control plane assistant when available (sonic-net#487) > [reboot script] add -h, -? options (sonic-net#484) Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Submodule src/sonic-sairedis 18ad5f9..4c75b7f: > Fixed conditional operator. (sonic-net#487) Submodule src/sonic-swss 1e99c93..cd12d48: > [teamsyncd]: Add information for LAG membership changes (sonic-net#982) > Fix vlan incremental config and add vs test cases (sonic-net#799) Signed-off-by: Ying Xie <ying.xie@microsoft.com>

swss: [vxlanorch]: Allow ipv6 src ip for Vxlan tunnel creation (sonic-net#896) [aclorch]: Allow DTEL drop actions in DTEL flow watchlist (sonic-net#915) Fix typo in orchagent_restart_check from fasle to false. (sonic-net#923) [sonic-swss]: Fix for FPM accept call failure in ARM arch (sonic-net#925) Add retryCount option for orchagent_restart_check program. (sonic-net#833) [vlan] Add pytest cases to validate nonexistent vlan behavior. (sonic-net#874) [intfsorch] Wait for interface prior to prefix (sonic-net#796) Set timer only when interval changes. Not in each firing of the timer. (sonic-net#945) [test]: Fix set interface in configuration database (sonic-net#956) [copporch]: Fix polymorphic type error (sonic-net#946) [AclOrch]: Fix the acl mirror counter doubled by inactive mirror and active again (sonic-net#952) [MirrorOrch]: Init the next hop ip with 0 instead of default constructor (sonic-net#953) [portsorch]: Add reference count of port (sonic-net#962) [mock_test]: Move mock tests into a separate folder to separate them from vs tests (sonic-net#950) remove crm acl_counters when acl_table removed (sonic-net#918) [aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (sonic-net#966) [policerorch]: Fix return code comparison error (sonic-net#968) [gitignore]: Add swss-dbg related files (sonic-net#967) [vxlanmgrd]: Fix for vxlanmgrd cannot correctly work after config reload (sonic-net#934) [vxlanorch]: Add extra info into NOTICE logs (sonic-net#891) [test]: Add a neighbor entry with BCAST MAC and verify its ignored (sonic-net#955) [copporch]: Fix copporch in DEL command (sonic-net#972) [orchagent]: Fix crash during orchagent process exit (sonic-net#974) [vnetorch]: Fix VNET orchagents order for warm-reboot flow (sonic-net#958) [test]: Skip unstable test test_vnet_orch_1 (sonic-net#976) [intfsorch]: Fix rif flex counter removal error (sonic-net#975) Update tests README.md file [aclorch]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (sonic-net#978) [test]: Skip test_watermark.py::TestWatermark::test_lua_plugins (sonic-net#981) [teamsyncd]: Add information for LAG membership changes (sonic-net#982) common: Add an assert to logger, which will log a message and abort. (sonic-net#286) [test]: Add IpAddress::isZero() unit test (sonic-net#289) do not abort when read timerfd return 0 and errno = 0 (sonic-net#291) Add BGP_STATE_TABLE in stateDB (sonic-net#273) [IpAddress]: add mcast scope on address and isFullMask method on prefix (sonic-net#285) Add ignore Wshadow pragma to json.hpp (sonic-net#292) [executor]: Fix Executor does not get correct priority saved in m_selectable (sonic-net#290) [schema]: Remove duplicate STATE_MIRROR_SESSION_TABLE_NAME (sonic-net#294) timerfd:read failure - Record in logs as error. (sonic-net#295) [schema]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (sonic-net#296) [schema]: Add PASS_THROUGH_ROUTE_TABLE to config and application db (sonic-net#297) sairedis: ARM32 bit fixes, for 64bit printf format specifier (sonic-net#468) Reduce the timeout (GET_RESPONSE_TIMEOUT) from 6 minutes to 1 minute. (sonic-net#472) Fixed config_syncd_barefoot function (sonic-net#474) [syncd_init_common.sh] fix fast reboot backwards compatibility (sonic-net#480) Add default bridge id for bridge port id of type PORT in virtual switch (sonic-net#473) Fix a bug in parsing kernel argument of fast-reboot (sonic-net#482) Add TimerWatchdog for monitoring long execution apis (sonic-net#469) Add specific comparison logic for tunnel map (sonic-net#475) [vslib] add ACL action capabilities support (sonic-net#481) Per buffer pool watermark polling mode (sonic-net#485) Add specific comparison logic for ACL counter (sonic-net#484) Process flex counters requests in separate thread (sonic-net#483) Make sairedis/syncd synchronous (sonic-net#476) Fixed conditional operator. (sonic-net#487) Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

swss: [vxlanorch]: Allow ipv6 src ip for Vxlan tunnel creation (#896) [aclorch]: Allow DTEL drop actions in DTEL flow watchlist (#915) Fix typo in orchagent_restart_check from fasle to false. (#923) [sonic-swss]: Fix for FPM accept call failure in ARM arch (#925) Add retryCount option for orchagent_restart_check program. (#833) [vlan] Add pytest cases to validate nonexistent vlan behavior. (#874) [intfsorch] Wait for interface prior to prefix (#796) Set timer only when interval changes. Not in each firing of the timer. (#945) [test]: Fix set interface in configuration database (#956) [copporch]: Fix polymorphic type error (#946) [AclOrch]: Fix the acl mirror counter doubled by inactive mirror and active again (#952) [MirrorOrch]: Init the next hop ip with 0 instead of default constructor (#953) [portsorch]: Add reference count of port (#962) [mock_test]: Move mock tests into a separate folder to separate them from vs tests (#950) remove crm acl_counters when acl_table removed (#918) [aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (#966) [policerorch]: Fix return code comparison error (#968) [gitignore]: Add swss-dbg related files (#967) [vxlanmgrd]: Fix for vxlanmgrd cannot correctly work after config reload (#934) [vxlanorch]: Add extra info into NOTICE logs (#891) [test]: Add a neighbor entry with BCAST MAC and verify its ignored (#955) [copporch]: Fix copporch in DEL command (#972) [orchagent]: Fix crash during orchagent process exit (#974) [vnetorch]: Fix VNET orchagents order for warm-reboot flow (#958) [test]: Skip unstable test test_vnet_orch_1 (#976) [intfsorch]: Fix rif flex counter removal error (#975) Update tests README.md file [aclorch]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (#978) [test]: Skip test_watermark.py::TestWatermark::test_lua_plugins (#981) [teamsyncd]: Add information for LAG membership changes (#982) common: Add an assert to logger, which will log a message and abort. (#286) [test]: Add IpAddress::isZero() unit test (#289) do not abort when read timerfd return 0 and errno = 0 (#291) Add BGP_STATE_TABLE in stateDB (#273) [IpAddress]: add mcast scope on address and isFullMask method on prefix (#285) Add ignore Wshadow pragma to json.hpp (#292) [executor]: Fix Executor does not get correct priority saved in m_selectable (#290) [schema]: Remove duplicate STATE_MIRROR_SESSION_TABLE_NAME (#294) timerfd:read failure - Record in logs as error. (#295) [schema]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (#296) [schema]: Add PASS_THROUGH_ROUTE_TABLE to config and application db (#297) sairedis: ARM32 bit fixes, for 64bit printf format specifier (#468) Reduce the timeout (GET_RESPONSE_TIMEOUT) from 6 minutes to 1 minute. (#472) Fixed config_syncd_barefoot function (#474) [syncd_init_common.sh] fix fast reboot backwards compatibility (#480) Add default bridge id for bridge port id of type PORT in virtual switch (#473) Fix a bug in parsing kernel argument of fast-reboot (#482) Add TimerWatchdog for monitoring long execution apis (#469) Add specific comparison logic for tunnel map (#475) [vslib] add ACL action capabilities support (#481) Per buffer pool watermark polling mode (#485) Add specific comparison logic for ACL counter (#484) Process flex counters requests in separate thread (#483) Make sairedis/syncd synchronous (#476) Fixed conditional operator. (#487) Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

* [201811][sairedis][swss] advance sub modules head Submodule src/sonic-sairedis 18ad5f9..4c75b7f: > Fixed conditional operator. (#487) Submodule src/sonic-swss 1e99c93..cd12d48: > [teamsyncd]: Add information for LAG membership changes (#982) > Fix vlan incremental config and add vs test cases (#799) Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [swss] include more swss changes Submodule src/sonic-swss cd12d48..f44029d: > [MirrorOrch]: Init the next hop ip with 0 instead of default constructor (#953) > [AclOrch]: Fix the acl mirror counter doubled by inactive mirror and active again (#952) Signed-off-by: Ying Xie <ying.xie@microsoft.com>

…c-net#487) Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

Includes below commits ``` bf8c832 2021-07-22 | Fix DBInterface blocking operations (#505) (HEAD -> 202012, origin/202012) [Qi Luo] 0e9385f 2021-04-21 | [swig] Implement SonicV2Connector.hmset() (#480) [Qi Luo] 76be49f 2021-07-25 | Modify the hardcode separator ":" to variable. (#473) [PJHsieh] 142ae3c 2021-06-23 | Fix config prompt question issue (#500) [xumia] e7bebe1 2021-06-14 | Fix repo reference issue (#487) [xumia] ```

[aboot]: add varlog limit file in aboot image

14a8642

qiluo-msft reviewed Apr 7, 2017

View reviewed changes

qiluo-msft requested changes Apr 7, 2017

View reviewed changes

qiluo-msft reviewed Apr 7, 2017

View reviewed changes

add more comments, unify the create_varlog

7cd263c

qiluo-msft approved these changes Apr 7, 2017

View reviewed changes

lguohan merged commit 1458e9e into sonic-net:master Apr 7, 2017

lguohan deleted the varlog branch November 6, 2017 04:32

lguohan mentioned this pull request Mar 22, 2019

[sonic-utilities]: fix sonic-utilities build error #2693

Merged

yxieca mentioned this pull request Mar 22, 2019

[201811][sonic-utilities] Advance submodule #2695

Merged

yxieca mentioned this pull request Jul 19, 2019

[201811][sairedis][swss] advance sub modules head #3189

Merged

stcheng mentioned this pull request Jul 19, 2019

[submodule]: Update swss related submodules #3190

Merged

Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019

[warm/fast reboot] setup control plane assistant when available (soni…

a30d1a8

…c-net#487) Signed-off-by: Ying Xie <ying.xie@microsoft.com>

dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020

Fixed conditional operator. (sonic-net#487)

736eb05

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[aboot]: add varlog limit file in aboot image #487

[aboot]: add varlog limit file in aboot image #487

lguohan commented Apr 7, 2017

lguohan commented Apr 7, 2017 •

edited by qiluo-msft

Loading

qiluo-msft Apr 7, 2017 •

edited

Loading

lguohan Apr 7, 2017 •

edited by qiluo-msft

Loading

lguohan Apr 7, 2017 •

edited by qiluo-msft

Loading

qiluo-msft Apr 7, 2017 •

edited

Loading

qiluo-msft Apr 7, 2017 •

edited

Loading

qiluo-msft Apr 7, 2017 •

edited

Loading

qiluo-msft left a comment

qiluo-msft Apr 7, 2017 •

edited

Loading

lguohan Apr 7, 2017

qiluo-msft Apr 7, 2017 •

edited

Loading

[aboot]: add varlog limit file in aboot image #487

[aboot]: add varlog limit file in aboot image #487

Conversation

lguohan commented Apr 7, 2017

lguohan commented Apr 7, 2017 • edited by qiluo-msft Loading

qiluo-msft Apr 7, 2017 • edited Loading

Choose a reason for hiding this comment

lguohan Apr 7, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

lguohan Apr 7, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

qiluo-msft Apr 7, 2017 • edited Loading

Choose a reason for hiding this comment

qiluo-msft Apr 7, 2017 • edited Loading

Choose a reason for hiding this comment

qiluo-msft Apr 7, 2017 • edited Loading

Choose a reason for hiding this comment

qiluo-msft left a comment

Choose a reason for hiding this comment

qiluo-msft Apr 7, 2017 • edited Loading

Choose a reason for hiding this comment

lguohan Apr 7, 2017

Choose a reason for hiding this comment

qiluo-msft Apr 7, 2017 • edited Loading

Choose a reason for hiding this comment

lguohan commented Apr 7, 2017 •

edited by qiluo-msft

Loading

qiluo-msft Apr 7, 2017 •

edited

Loading

lguohan Apr 7, 2017 •

edited by qiluo-msft

Loading

lguohan Apr 7, 2017 •

edited by qiluo-msft

Loading

qiluo-msft Apr 7, 2017 •

edited

Loading

qiluo-msft Apr 7, 2017 •

edited

Loading

qiluo-msft Apr 7, 2017 •

edited

Loading

qiluo-msft Apr 7, 2017 •

edited

Loading

qiluo-msft Apr 7, 2017 •

edited

Loading