Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Credo][Ycable] fix incorrect uart statistics #296

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

xinyulin
Copy link
Contributor

Signed-off-by: xinyu xinyu0123@gmail.com

Description

The original get_uart_stat() will only report the last record of the uart statistic due to all record shared the same object instance.

Motivation and Context

How Has This Been Tested?

Additional Information (Optional)

Signed-off-by: xinyu <xinyu0123@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Jul 30, 2022

This pull request introduces 1 alert when merging 56afe8a into 50c24a5 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

Signed-off-by: xinyu <xinyu0123@gmail.com>
@lguohan
Copy link
Contributor

lguohan commented Aug 11, 2022

/easycla

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 11, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@vdahiya12 vdahiya12 merged commit 030a382 into sonic-net:master Aug 12, 2022
qiluo-msft pushed a commit that referenced this pull request Aug 12, 2022
Description
The original get_uart_stat() will only report the last record of the uart statistic due to all record shared the same object instance.

Motivation and Context
How Has This Been Tested?

Signed-off-by: xinyu <xinyu0123@gmail.com>
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Aug 29, 2022
Update sonic-platform-common submodule pointer to include the following:
* [CMIS] Catch Exception to avoid CMIS code crash ([sonic-net#299](sonic-net/sonic-platform-common#299))
* [Credo][Ycable] fix incorrect uart statistics ([sonic-net#296](sonic-net/sonic-platform-common#296))
* Add PSU input voltage and input current ([sonic-net#295](sonic-net/sonic-platform-common#295))

Signed-off-by: dprital <drorp@nvidia.com>
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Sep 4, 2022
Update sonic-platform-common submodule pointer to include the following:
* [CMIS] 'get_transceiver_info' should return 'None' when CMIS cable EEPROM is not ready  ([sonic-net#305](sonic-net/sonic-platform-common#305))
* uplift code coverage 80% ([sonic-net#307](sonic-net/sonic-platform-common#307))
* [sonic-pcie] Add UT for pcie_common.py ([sonic-net#293](sonic-net/sonic-platform-common#293))
* [CMIS] Catch Exception to avoid CMIS code crash ([sonic-net#299](sonic-net/sonic-platform-common#299))
* [Credo][Ycable] fix incorrect uart statistics ([sonic-net#296](sonic-net/sonic-platform-common#296))
* Add PSU input voltage and input current ([sonic-net#295](sonic-net/sonic-platform-common#295))

Signed-off-by: dprital <drorp@nvidia.com>
@xinyulin xinyulin deleted the credo_dump_reg branch April 17, 2023 02:06
yxieca pushed a commit that referenced this pull request Aug 10, 2023
Description
The original get_uart_stat() will only report the last record of the uart statistic due to all record shared the same object instance.

Motivation and Context
How Has This Been Tested?

Signed-off-by: xinyu <xinyu0123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants