[flow counter] Fix issue: should not compare str with int #2001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
approved these changes
Jan 7, 2022
dgsudharsan
approved these changes
Jan 8, 2022
prsunny
approved these changes
Jan 11, 2022
|
Hi @prsunny, could you please help cherry-pick to 202111? |
|
Hi @judyjoseph , could you please help cherry-pick to 202111? |
judyjoseph
pushed a commit
that referenced
this pull request
Jan 17, 2022
*When clearing stats, current flow counter stats is serialized to a file for further compare. All stats value is saved as string value. When doing diff, the loaded stats value shall be convert into int and do the compare. The PR is to fix this issue.
manish1-arista
added a commit
to manish1-arista/sonic-utilities
that referenced
this pull request
Aug 25, 2025
* Caching the current counters when sonic-clear queuecounters is executed. * Calculating and displaying the difference in counter values when the show command is run. * Providing clear CLI messaging to indicate the behavior when run from supervisor(clear aggregate VOQ counters only). * Unit test for clear aggregate VOQ counters is added verifying the data is cached and counters are cleared properly.
manish1-arista
added a commit
to manish1-arista/sonic-utilities
that referenced
this pull request
Aug 25, 2025
…t#2001) * Caching the current counters when sonic-clear queuecounters is executed. * Calculating and displaying the difference in counter values when the show command is run. * Providing clear CLI messaging to indicate the behavior when run from supervisor(clear aggregate VOQ counters only). * Unit test for clear aggregate VOQ counters is added verifying the data is cached and counters are cleared properly. Signed-off-by: manish <manish1@arista.com>
manish1-arista
added a commit
to manish1-arista/sonic-utilities
that referenced
this pull request
Aug 27, 2025
…t#2001) * Caching the current counters when sonic-clear queuecounters is executed. * Calculating and displaying the difference in counter values when the show command is run. * Providing clear CLI messaging to indicate the behavior when run from supervisor(clear aggregate VOQ counters only). * Unit test for clear aggregate VOQ counters is added verifying the data is cached and counters are cleared properly. Signed-off-by: manish <manish1@arista.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When clearing stats, current flow counter stats is serialized to a file for further compare. All stats value is saved as string value. When doing diff, the loaded stats value shall be convert into int and do the compare. The PR is to fix this issue.
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)