-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to svgo v3 #10
Conversation
52fec67
to
e85f39f
Compare
fdc1742
to
dd7e417
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thank you
{ | ||
id: "removeDoctype", | ||
name: "Remove doctype", | ||
enabledByDefault: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use this file from svgo instead directly ?
https://github.com/jakearchibald/svgomg/blob/main/src/config.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently don't have a file like that, nor export enough for clients to derive it programmatically, I don't think.
(Note that your link is to SVGOMG, not SVGO!)
It is possible to get a list of all plugins, which includes the default preset (preset-default
), but from there, not which plugins are the default nor a clean name for them that can be displayed in the UI.
Following the discussion in jakearchibald/svgomg#431, we're already evaluating what would be best to expose this kind of information so it's easier for clients.
If you're cool with it, I'll come back to you with another PR later once we have something in place and help with migrating. 👍🏽
Feel free to add your name to contributors in |
dd7e417
to
d881b8a
Compare
Hey! I'm trying to get all libraries/client that use SVGO upgraded to the latest release, which has many bug fixes.
Consider checking out the changelog of the last two releases:
https://github.com/svg/svgo/releases
This migrates OhMySVG from SVGO v2 to SVGO v3, I've tried to take an approach similar to SVGOMG where I can.
Changes
make test
in VSC installed via snap, I had to open a normal terminal instance.)cleanupIDs
tocleanupIds
, renamed in SVGO v3.sort*
plugins to the end of the list, as these work best when run last.convertOneStopGradients
andremoveXlink
.