Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library: Add Level Bars entry #238

Merged
merged 8 commits into from
Mar 21, 2023
Merged

library: Add Level Bars entry #238

merged 8 commits into from
Mar 21, 2023

Conversation

AkshayWarrier
Copy link
Contributor

Adds level bars entry.

  • For continuous mode, I've tried to replicate GNOME's battery status widget
  • For discrete mode, I have tried my best to eliminate edge cases. I have kept the criteria for password strength fairly loose i.e it's easy to make a strong password. This is mainly because I want all the levels to be discovered quickly. But this can be changed as per discussion.
  • The colors for password strength, I haven't done separate styling for light mode/dark mode but I have chosen colors that should be equally visible in both. I can change this if need be.

Issue workbenchdev/demos#3

@sonnyp sonnyp self-requested a review March 18, 2023 23:56
sonnyp
sonnyp requested changes Mar 19, 2023
View reviewed changes
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good

src/Library/demos/Level Bars/main.blp Outdated Show resolved Hide resolved
src/Library/demos/Level Bars/main.blp Outdated Show resolved Hide resolved
src/Library/demos/Level Bars/main.blp Show resolved Hide resolved
src/Library/demos/Level Bars/main.blp Outdated Show resolved Hide resolved
src/Library/demos/Level Bars/main.blp Outdated Show resolved Hide resolved
src/Library/demos/Level Bars/main.blp Outdated Show resolved Hide resolved
src/Library/demos/Level Bars/main.blp Outdated Show resolved Hide resolved
src/Library/demos/Level Bars/main.js Outdated Show resolved Hide resolved
@sonnyp sonnyp self-assigned this Mar 19, 2023
sonnyp
sonnyp approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I made slight changes to use Adw.StatusPage, simplify a bit and warn about the password strength method being insecure to be sincere with users.

@sonnyp sonnyp merged commit ceb5662 into workbenchdev:main Mar 21, 2023
@AkshayWarrier
Copy link
Contributor Author

Thanks :)

@AkshayWarrier AkshayWarrier deleted the add-level-bars-entry branch March 24, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonnyp sonnyp sonnyp approved these changes

Assignees

@sonnyp sonnyp

Labels
Library 📚️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AkshayWarrier @sonnyp