Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library: Add Overlay entry #251

Merged
merged 3 commits into from
Mar 26, 2023
Merged

Conversation

AkshayWarrier
Copy link
Contributor

Adds overlay entry
Issue workbenchdev/demos#3

@AkshayWarrier
Copy link
Contributor Author

AkshayWarrier commented Mar 26, 2023

I'm unsure on how I should demonstrate interaction with the background when it's a Gtk.Picture

  1. What should happen when someone clicks/hovers on the picture
  2. How do I listen for that event on a Gtk.Picture

Right now I have added a simple darkening effect to the osd on hover

Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should happen when someone clicks/hovers on the picture

yeah it's not super straightforward - let's leave it out for now - we can always improve this demo later 👍

src/Library/demos/Overlay/main.js Outdated Show resolved Hide resolved
src/Library/demos/Overlay/main.json Outdated Show resolved Hide resolved
src/Library/demos/Overlay/main.blp Show resolved Hide resolved
@sonnyp sonnyp self-assigned this Mar 26, 2023
@sonnyp
Copy link
Contributor

sonnyp commented Mar 26, 2023

For later here is an interesting use case

Screencast.from.2023-03-26.14-47-31.webm

@AkshayWarrier AkshayWarrier marked this pull request as ready for review March 26, 2023 13:41
@sonnyp sonnyp merged commit 18cf482 into workbenchdev:main Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants