library: Add Overlay entry#251
Merged
sonnyp merged 3 commits intoworkbenchdev:mainfrom Mar 26, 2023
Merged
Conversation
Contributor
Author
|
I'm unsure on how I should demonstrate interaction with the background when it's a
Right now I have added a simple darkening effect to the osd on hover |
sonnyp
reviewed
Mar 26, 2023
Contributor
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
What should happen when someone clicks/hovers on the picture
yeah it's not super straightforward - let's leave it out for now - we can always improve this demo later 👍
Contributor
|
For later here is an interesting use case Screencast.from.2023-03-26.14-47-31.webm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds overlay entry
Issue workbenchdev/demos#3