library: Add Email Entry #330

SoNiC-HeRE · 2023-06-13T16:06:28Z

Closes #329

SoNiC-HeRE · 2023-06-13T16:06:35Z

@andyholmes Can you please provide an early review for the email demo?
As of last time it seemed to work for everyone else, so just wanna make sure if it's a permission error or something else

sonnyp

works for me

the issue might be that you don't have an email application

sonnyp · 2023-06-14T10:33:49Z

Please make sure to use Gio._promisify

SoNiC-HeRE · 2023-06-14T10:35:40Z

Please make sure to use Gio._promisify

Yes , i was just making sure if it was a problem on my side.

Idk if it's relevant or not but shouldn't it be triggered if there's no email app on the user?

For example: if user hasn't installed any email app, browser should be accessed with an email template

SoNiC-HeRE · 2023-06-14T11:55:26Z

This worked fine for me when i installed the app :)

sonnyp

It would be nice to add a text input inviting the user to enter their email address and use it for the addresses arg.

This way, when the user can test by sending the email to themselves directly.

wdyt?

sonnyp · 2023-06-15T19:57:59Z

src/Library/demos/Email/main.blp

+using Adw 1;
+
+Adw.StatusPage {
+  title: "Email";


all user visible strings should be wrapper in _()

please try to remember

Suggested change

title: "Email";

title: _("Email");

sonnyp · 2023-06-15T19:58:57Z

src/Library/demos/Email/main.blp

+      label: _("Send Email");
+      margin-bottom: 42;
+      halign: center;
+      styles ["suggested-action"]


Suggested change

styles ["suggested-action"]

styles ["suggested-action", "pill"]

for buttons outside of toolbars

sonnyp · 2023-06-15T20:00:11Z

src/Library/demos/Email/main.js

+      ["sonicworks05@gmail.com"],
+      ["test@gmail.com"],
+      null,
+      "Demo Message",


can you add a comment next to each line with the name of the argument so it's clear what is what?

For example here

Suggested change

"Demo Message",

"Demo Message", // subject

sonnyp · 2023-06-15T20:01:19Z

src/Library/demos/Email/main.js

+      ["sonicworks05@gmail.com"],
+      ["test@gmail.com"],


Please don't use your personal data in examples.

Suggested change

["sonicworks05@gmail.com"],

["test@gmail.com"],

["example@example.com"], // addresses

null, // cc

sonnyp · 2023-06-15T20:05:55Z

src/Library/demos/Email/main.js

+  }
+}
+
+button.connect("clicked", sendEmail);


I have updated our practice a bit here see #339

Please remove the try catch from sendEmail to make the function simpler and do the following instead

Suggested change

button.connect("clicked", sendEmail);

button.connect("clicked", () => {

onClicked().catch(logError);

));

sonnyp · 2023-06-15T20:09:01Z

src/Library/demos/Email/main.js

+      ["sonicworks05@gmail.com"],
+      ["test@gmail.com"],


Please don't use your personal data in examples.

Suggested change

["sonicworks05@gmail.com"],

["test@gmail.com"],

["example@example.com"], // addresses

null, // cc

sonnyp · 2023-06-15T20:12:35Z

src/Library/demos/Email/main.js

+      ["test@gmail.com"],
+      null,
+      "Demo Message",
+      "Demo Content",


I would suggest "Email from Workbench" as subject and "Hello World!" as body

sonnyp · 2023-06-15T20:14:25Z

src/Library/demos/Email/main.json

+{
+  "name": "Email",
+  "category": "platform",
+  "description": "Compose an email message",


remember to write description from the perspective of the developer

Suggested change

"description": "Compose an email message",

"description": "Trigger an email",

sonnyp · 2023-06-15T20:15:35Z

src/Library/demos/Email/main.js

+
+async function sendEmail() {
+  try {
+    const result = await portal.compose_email(


Suggested change

const result = await portal.compose_email(

const success = await portal.compose_email(

sonnyp · 2023-06-15T20:17:53Z

src/Library/demos/Email/main.js

+    if (result) {
+      console.log("Email app opened");
+    }


It could be a web app or the app could already be opened. It's best not to be overly specific if we don't know for sure what will happen.

Also we know from your experience what a case for failure can be so maybe we can help the user figure it out.

Suggested change

if (result) {

console.log("Email app opened");

}

if (success) {

console.log("Success");

} else {

console.log("Failure, verify that you have a register email application.");

}

sonnyp · 2023-06-15T20:22:21Z

src/Library/demos/Email/main.blp

+
+Adw.StatusPage {
+  title: "Email";
+  description: _("Compose an email");


Suggested change

description: _("Compose an email");

description: _("Trigger an email");

SoNiC-HeRE · 2023-06-16T06:25:57Z

It would be nice to add a text input inviting the user to enter their email address and use it for the addresses arg.

This way, when the user can test by sending the email to themselves directly.

wdyt?

Sure, it's a good idea

SoNiC-HeRE · 2023-06-16T07:10:18Z

Made the following changes

Used a Gtk.Entry to take email from user
Commented various properties of portal.compose_email method
Implemented an email validator
Refined Code
Removed async handlers

* Adds Adw.AboutWindow Demo * Updated Link * Updated Code * Updated Icon * Added Acknowledgement Section

* library: Add AdwAnimation entry * Animation: Fix CallbackAnimationTarget and add AnimationTarget example * Animation: Add links * Animation: Changes from review * Animation: Update main.css

* Added TextView Demo * Updated JS Code * Updated Code * Formatting Changes

* libary: Add SpinButton entry * Spin Button: Add link to tutorial * Spin Button: Changes from review * Spin Button: Translated strings * Spin Button: Add comments for clarity

* library: Add AdwBanner entry * Banner: Translate strings

sonnyp

Well done.

I made minor changes a3966fb

Make sure to use the name of arguments as defined by the API documentation next time.

Adds Email Demo

764a0f6

SoNiC-HeRE added the Library 📚️ label Jun 14, 2023

sonnyp reviewed Jun 14, 2023

View reviewed changes

Refined Code

8d9971e

sonnyp reviewed Jun 15, 2023

View reviewed changes

sonnyp mentioned this pull request Jun 15, 2023

library: Adds ColorPicker Demo #335

Merged

SoNiC-HeRE added 2 commits June 16, 2023 12:25

Applied Suggested Changes

beb68fd

Minor Change

bf903a1

SoNiC-HeRE requested a review from sonnyp June 16, 2023 16:52

SoNiC-HeRE and others added 10 commits June 17, 2023 19:12

library: Adds Adw.AboutWindow entry (#305)

3616f1e

* Adds Adw.AboutWindow Demo * Updated Link * Updated Code * Updated Icon * Added Acknowledgement Section

library: Add Animation entry (#306)

cea863c

* library: Add AdwAnimation entry * Animation: Fix CallbackAnimationTarget and add AnimationTarget example * Animation: Add links * Animation: Changes from review * Animation: Update main.css

library: Adds TextView entry (#315)

5c7ce18

* Added TextView Demo * Updated JS Code * Updated Code * Formatting Changes

library: Minor improvements

b59cd30

library: add css example (#314)

9dd6f0d

Library: Drawing Area, reduce dependencies (#327)

1550f94

library: Add SpinButton entry (#312)

967d766

* libary: Add SpinButton entry * Spin Button: Add link to tutorial * Spin Button: Changes from review * Spin Button: Translated strings * Spin Button: Add comments for clarity

library: Add AdwBanner entry (#313)

12d9704

* library: Add AdwBanner entry * Banner: Translate strings

Merge branch 'main' into sonic/email

c993274

Minor changes

a3966fb

sonnyp force-pushed the sonic/email branch from 27fad69 to a3966fb Compare June 17, 2023 17:18

sonnyp approved these changes Jun 17, 2023

View reviewed changes

sonnyp changed the title ~~library: Adds Email Entry~~ library: Add Email Entry Jun 17, 2023

sonnyp merged commit b91b013 into main Jun 17, 2023

sonnyp deleted the sonic/email branch June 17, 2023 17:19

sonnyp pushed a commit that referenced this pull request Jun 20, 2023

library: Add Email Entry (#330)

a3064aa

sonnyp pushed a commit to SoNiC-HeRE/Workbench that referenced this pull request Aug 13, 2023

library: Add Email Entry (workbenchdev#330)

412cfa2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

library: Add Email Entry #330

library: Add Email Entry #330

SoNiC-HeRE commented Jun 13, 2023

SoNiC-HeRE commented Jun 13, 2023

sonnyp left a comment

sonnyp commented Jun 14, 2023

SoNiC-HeRE commented Jun 14, 2023 •

edited

SoNiC-HeRE commented Jun 14, 2023

sonnyp left a comment

sonnyp Jun 15, 2023

sonnyp Jun 15, 2023

sonnyp Jun 15, 2023

sonnyp Jun 15, 2023

sonnyp Jun 15, 2023

sonnyp Jun 15, 2023

sonnyp Jun 15, 2023

sonnyp Jun 15, 2023 •

edited

sonnyp Jun 15, 2023

sonnyp Jun 15, 2023

sonnyp Jun 15, 2023

SoNiC-HeRE commented Jun 16, 2023

SoNiC-HeRE commented Jun 16, 2023

sonnyp left a comment

	styles ["suggested-action"]
	styles ["suggested-action", "pill"]

-button.connect("clicked", sendEmail);
+button.connect("clicked", () => {
+  onClicked().catch(logError);
+));

	"description": "Compose an email message",
	"description": "Trigger an email",

	const result = await portal.compose_email(
	const success = await portal.compose_email(

-    if (result) {
-      console.log("Email app opened");
-    }
+    if (success) {
+      console.log("Success");
+    } else {
+      console.log("Failure, verify that you have a register email application.");
+    }

	description: _("Compose an email");
	description: _("Trigger an email");

library: Add Email Entry #330

library: Add Email Entry #330

Conversation

SoNiC-HeRE commented Jun 13, 2023

SoNiC-HeRE commented Jun 13, 2023

sonnyp left a comment

Choose a reason for hiding this comment

sonnyp commented Jun 14, 2023

SoNiC-HeRE commented Jun 14, 2023 • edited

SoNiC-HeRE commented Jun 14, 2023

sonnyp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonnyp Jun 15, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SoNiC-HeRE commented Jun 16, 2023

SoNiC-HeRE commented Jun 16, 2023

sonnyp left a comment

Choose a reason for hiding this comment

SoNiC-HeRE commented Jun 14, 2023 •

edited

sonnyp Jun 15, 2023 •

edited