Skip to content

library: add css example #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 14, 2023
Merged

library: add css example #314

merged 9 commits into from
Jun 14, 2023

Conversation

@halfmexican
Copy link
Contributor

@halfmexican halfmexican commented Jun 10, 2023

closes #58

@halfmexican halfmexican linked an issue Jun 10, 2023 that may be closed by this pull request
Add example explaining how to use CSS #58
Closed
@halfmexican
Copy link
Contributor Author

halfmexican commented Jun 11, 2023

I feel like more needs to be done, so I'll leave this up to review to decide what that is.

@halfmexican halfmexican marked this pull request as ready for review June 11, 2023 03:32
@halfmexican halfmexican changed the title library:add css example library: add css example Jun 11, 2023
@halfmexican halfmexican requested review from andyholmes and sonnyp June 13, 2023 15:53
@sonnyp sonnyp removed the request for review from andyholmes June 14, 2023 08:34
sonnyp
sonnyp approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some small improvements 0ee82d2

Comment for later:

This would be a great candidate for some kind of tutorial format where we can go through every CSS feature.

Ideally, we would also demonstrate CSS animations.

@sonnyp sonnyp merged commit f7db425 into main Jun 14, 2023
@sonnyp sonnyp deleted the halfmexican/css-example branch June 14, 2023 08:59
sonnyp pushed a commit that referenced this pull request Jun 17, 2023
@halfmexican @sonnyp
library: add css example (#314)
9dd6f0d
sonnyp pushed a commit that referenced this pull request Jun 17, 2023
@halfmexican @sonnyp
library: add css example (#314)
744ba37
sonnyp pushed a commit that referenced this pull request Jun 20, 2023
@halfmexican @sonnyp
library: add css example (#314)
d71dfa6
sonnyp pushed a commit to SoNiC-HeRE/Workbench that referenced this pull request Aug 13, 2023
@halfmexican @sonnyp
library: add css example (workbenchdev#314)
194bf06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sonnyp sonnyp sonnyp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add example explaining how to use CSS

3 participants

@halfmexican @sonnyp