library: Do not use async handlers #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signal handlers have semantic around return values. Let's not encourage developers to use async signal handlers as it can lead to hard to debug issues. Also some other improvements
sonnyp
commented
Jun 15, 2023
andyholmes
approved these changes
Jun 15, 2023
Contributor
andyholmes
left a comment
andyholmes
left a comment
There was a problem hiding this comment.
Nice one, lots of good cleanups in here.
sonnyp
added a commit
that referenced
this pull request
Jun 20, 2023
Signal handlers have semantic around return values. Let's not encourage developers to use async signal handlers as it can lead to hard to debug issues. Also some other improvements
sonnyp
added a commit
to SoNiC-HeRE/Workbench
that referenced
this pull request
Aug 13, 2023
Signal handlers have semantic around return values. Let's not encourage developers to use async signal handlers as it can lead to hard to debug issues. Also some other improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signal handlers have semantic around return values.
Let's not encourage developers to use async signal handlers, as it can lead to hard to debug issues.
Also, some other improvements