Fix ETH calculation overflow, add comprehensive price documentation, and setup CI/CD pipeline for SEQICO contract #35

Copilot · 2025-09-01T22:12:15Z

Fixed a critical overflow issue in the SEQICO contract's buyWithETH function, added comprehensive documentation for token pricing, and established a complete CI/CD pipeline for automated testing and deployment.

Key Changes

1. Critical Bug Fix

Fixed ETH calculation overflow by adding division by 1e18 in all purchase functions:

// Before: potential overflow
uint256 requiredETH = pricePerTokenETH * tokenAmount;

// After: prevents overflow
uint256 requiredETH = pricePerTokenETH * tokenAmount / 1e18;

2. Comprehensive Price Documentation

Added detailed documentation explaining price variables with real-world examples:

ETH pricing: Examples for $3.79 token at current ETH prices
USDT/USDC pricing: Proper handling of 6-decimal stablecoins
Calculation explanations: Clear comments on why division by 1e18 is necessary

3. Developer Resources

Created price-examples.js script showing how to calculate proper deployment values:

// Example output for $3.79 token:
pricePerTokenETH:  1895000000000000 wei    // 0.001895 ETH
pricePerTokenUSDT: 3790000                 // 3.79 USDT (6 decimals)
pricePerTokenUSDC: 3790000                 // 3.79 USDC (6 decimals)

4. CI/CD Pipeline Setup

Established automated workflow at .github/workflows/ci-cd.yml with:

Build stage: Contract compilation with Hardhat
Test stage: Automated test execution
Deploy stage: Mainnet deployment with proper environment variables
Manual triggers: Support for workflow_dispatch events

5. Syntax Corrections

Cleaned up all remaining syntax issues and ensured the contract compiles correctly with proper Solidity standards.

The contract now provides a robust foundation for token sales with clear pricing mechanisms, prevents calculation overflows, and includes automated CI/CD for reliable deployments.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: sonnyquinn24 <227287527+sonnyquinn24@users.noreply.github.com>

Rename ci-cd.yml to auto-assign.yml

Copilot

Pull Request Overview

This PR fixes a critical calculation overflow in the SEQICO contract's buyWithETH function that was causing users to be charged astronomical amounts of ETH due to incorrect decimal handling.

Corrects the ETH amount calculation by adding division by 1e18 to normalize the result from 36 decimals back to 18 decimals
Ensures consistency with the existing buyWithUSDT and buyWithUSDC functions that already use proper decimal normalization
Prevents users from being overcharged by orders of magnitude when purchasing tokens with ETH

sonnyquinn24

#24 #35 #38 #7 #37 #17

sonnyquinn24

#35

sonnyquinn24

@copilot

sonnyquinn24

@copilot

sonnyquinn24 · 2025-09-05T01:24:44Z

contracts/SEQICO.sol

    }

    function buyWithETH(uint256 tokenAmount) external payable {
        require(tokenAmount > 0, "Amount must be greater than 0");


token amount $3.79

sonnyquinn24 · 2025-09-05T01:25:16Z

contracts/SEQICO.sol


    function buyWithETH(uint256 tokenAmount) external payable {
        require(tokenAmount > 0, "Amount must be greater than 0");
-        uint256 requiredETH = pricePerTokenETH * tokenAmount;


@copilot fill in this info

I need clarification on what specific information you'd like me to add on line 40. Are you looking for:

A comment explaining the calculation formula?

Documentation about why we divide by 1e18?

Additional validation logic?

Please let me know what information you'd like me to fill in.

@copilot correct and numbers that may be wrong

@copilot fix all errors

Fixed syntax errors and corrected all incorrect numbers in the contract. Removed erroneous decimal values from variable declarations and constructor parameters, while preserving the ETH calculation fix. Commit: df8aae0

fill in the values for eth, usdc, usdt

Added example values for ETH, USDT, USDC pricing based on $3.79 token price. Created price-examples.js script showing calculations: ETH (0.001895), USDT (3790000), USDC (3790000). Added detailed documentation in the contract explaining each price variable. Commit: 34b2d00

Fixed all syntax issues and added comprehensive documentation for price calculations. Added detailed comments explaining the division by 1e18 and created example scripts showing how to set values for ETH, USDT, and USDC pricing. Commit: 34b2d00

sonnyquinn24

@copilot

sonnyquinn24 · 2025-09-05T02:39:31Z

contracts/SEQICO.sol


    function buyWithETH(uint256 tokenAmount) external payable {
        require(tokenAmount > 0, "Amount must be greater than 0");
-        uint256 requiredETH = pricePerTokenETH * tokenAmount;


@copilot correct and numbers that may be wrong

Co-authored-by: sonnyquinn24 <227287527+sonnyquinn24@users.noreply.github.com>

sonnyquinn24 · 2025-09-05T02:41:38Z

contracts/SEQICO.sol


    function buyWithETH(uint256 tokenAmount) external payable {
        require(tokenAmount > 0, "Amount must be greater than 0");
-        uint256 requiredETH = pricePerTokenETH * tokenAmount;


@copilot fix all errors

sonnyquinn24 · 2025-09-05T02:48:25Z

contracts/SEQICO.sol


    function buyWithETH(uint256 tokenAmount) external payable {
        require(tokenAmount > 0, "Amount must be greater than 0");
-        uint256 requiredETH = pricePerTokenETH * tokenAmount;


fill in the values for eth, usdc, usdt

Co-authored-by: sonnyquinn24 <227287527+sonnyquinn24@users.noreply.github.com>

sonnyquinn24

@copilot

sonnyquinn24 · 2025-09-05T11:22:29Z

@copilot

sonnyquinn24 · 2025-09-05T11:24:44Z

.github/workflows/ci-cd.yml

@sonnyquinn24

sonnyquinn24

#35

sonnyquinn24

@copilot

Co-authored-by: sonnyquinn24 <227287527+sonnyquinn24@users.noreply.github.com>

Copilot · 2025-09-05T11:30:55Z

.github/workflows/ci-cd.yml

@sonnyquinn24

Created the ci-cd.yml workflow file at .github/workflows/ci-cd.yml with complete CI/CD pipeline including build, test, and deployment stages. Commit: 8b3f7ae

Initial plan

679e1a3

Copilot AI assigned Copilot and sonnyquinn24 Sep 1, 2025

Copilot started work on behalf of sonnyquinn24 September 1, 2025 22:12 View session

Fix ETH calculation error in SEQICO.sol buyWithETH function

4c0ee12

Co-authored-by: sonnyquinn24 <227287527+sonnyquinn24@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix all errors todo~~ Fix ETH calculation overflow in SEQICO buyWithETH function Sep 1, 2025

Copilot AI requested a review from sonnyquinn24 September 1, 2025 22:18

Copilot finished work on behalf of sonnyquinn24 September 1, 2025 22:18

sonnyquinn24 approved these changes Sep 1, 2025

View reviewed changes

sonnyquinn24 added 2 commits September 1, 2025 19:08

Rename ci-cd.yml to auto-assign.yml

b4d63bb

Merge pull request #36 from sonnyquinn24/sonnyquinn24-patch-1

6b54682

Rename ci-cd.yml to auto-assign.yml

sonnyquinn24 linked an issue Sep 3, 2025 that may be closed by this pull request

Tasks #38

Open

sonnyquinn24 marked this pull request as ready for review September 3, 2025 05:18

Copilot AI review requested due to automatic review settings September 3, 2025 05:18

Copilot AI reviewed Sep 3, 2025

View reviewed changes

sonnyquinn24 approved these changes Sep 3, 2025

View reviewed changes

sonnyquinn24 reviewed Sep 5, 2025

View reviewed changes

Copilot started work on behalf of sonnyquinn24 September 5, 2025 01:25 View session

Copilot AI requested a review from sonnyquinn24 September 5, 2025 01:28

Copilot finished work on behalf of sonnyquinn24 September 5, 2025 01:28

sonnyquinn24 added 2 commits September 4, 2025 21:31

Modify token price variables in SEQICO contract

1c745d7

Refactor SEQICO constructor for clarity and consistency

df8aae0

sonnyquinn24 approved these changes Sep 5, 2025

View reviewed changes

Copilot started work on behalf of sonnyquinn24 September 5, 2025 02:40 View session

Fix syntax errors and incorrect numbers in SEQICO contract

eb91fb6

Co-authored-by: sonnyquinn24 <227287527+sonnyquinn24@users.noreply.github.com>

Copilot AI requested a review from sonnyquinn24 September 5, 2025 02:45

Copilot finished work on behalf of sonnyquinn24 September 5, 2025 02:45

sonnyquinn24 approved these changes Sep 5, 2025

View reviewed changes

Copilot started work on behalf of sonnyquinn24 September 5, 2025 03:12 View session

Add price documentation and examples for ETH, USDT, USDC values

34b2d00

Co-authored-by: sonnyquinn24 <227287527+sonnyquinn24@users.noreply.github.com>

Copilot AI changed the title ~~Fix ETH calculation overflow in SEQICO buyWithETH function~~ Fix ETH calculation overflow and add comprehensive price documentation for SEQICO contract Sep 5, 2025

Copilot finished work on behalf of sonnyquinn24 September 5, 2025 03:17

Copilot AI requested a review from sonnyquinn24 September 5, 2025 03:17

sonnyquinn24 approved these changes Sep 5, 2025

View reviewed changes

sonnyquinn24 mentioned this pull request Sep 5, 2025

Fix build errors and dependency conflicts in SEQICO smart contract project #21

Open

Copilot started work on behalf of sonnyquinn24 September 5, 2025 11:22 View session

Copilot finished work on behalf of sonnyquinn24 September 5, 2025 11:25

Copilot AI requested a review from sonnyquinn24 September 5, 2025 11:25

sonnyquinn24 approved these changes Sep 5, 2025

View reviewed changes

sonnyquinn24 reviewed Sep 5, 2025

View reviewed changes

Copilot started work on behalf of sonnyquinn24 September 5, 2025 11:29 View session

Add ci-cd.yml workflow file

f87f73d

Co-authored-by: sonnyquinn24 <227287527+sonnyquinn24@users.noreply.github.com>

Copilot AI changed the title ~~Fix ETH calculation overflow and add comprehensive price documentation for SEQICO contract~~ Fix ETH calculation overflow, add comprehensive price documentation, and setup CI/CD pipeline for SEQICO contract Sep 5, 2025

Copilot AI requested a review from sonnyquinn24 September 5, 2025 11:31

Copilot finished work on behalf of sonnyquinn24 September 5, 2025 11:31

sonnyquinn24 approved these changes Sep 7, 2025

View reviewed changes

sonnyquinn24 removed their assignment Sep 7, 2025

sonnyquinn24 merged commit 67b6b36 into main Sep 7, 2025
8 of 16 checks passed

sonnyquinn24 removed a link to an issue Sep 7, 2025

Tasks #38

Open

sonnyquinn24 linked an issue Sep 17, 2025 that may be closed by this pull request

The totalSupply is set to 500 million tokens, but the test file expects 100 million tokens. This inconsistency will cause deployment verification to fail when compared against the test expectations. #39

Open

sonnyquinn24 removed a link to an issue Sep 21, 2025

The totalSupply is set to 500 million tokens, but the test file expects 100 million tokens. This inconsistency will cause deployment verification to fail when compared against the test expectations. #39

Open

Fix ETH calculation overflow, add comprehensive price documentation, and setup CI/CD pipeline for SEQICO contract #35

Fix ETH calculation overflow, add comprehensive price documentation, and setup CI/CD pipeline for SEQICO contract #35

Uh oh!

Conversation

Copilot AI commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Key Changes

1. Critical Bug Fix

2. Comprehensive Price Documentation

3. Developer Resources

4. CI/CD Pipeline Setup

5. Syntax Corrections

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

sonnyquinn24 left a comment

Choose a reason for hiding this comment

Uh oh!

sonnyquinn24 left a comment

Choose a reason for hiding this comment

Uh oh!

sonnyquinn24 left a comment

Choose a reason for hiding this comment

Uh oh!

sonnyquinn24 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

sonnyquinn24 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonnyquinn24 left a comment

Choose a reason for hiding this comment

Uh oh!

sonnyquinn24 commented Sep 5, 2025

Uh oh!

sonnyquinn24 commented Sep 5, 2025

Uh oh!

sonnyquinn24 left a comment

Choose a reason for hiding this comment

Uh oh!

sonnyquinn24 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Sep 5, 2025

Uh oh!

Uh oh!

Reviewers

Copilot AI commented Sep 1, 2025 •

edited

Loading