Fix warning suppression in the json utility. #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly push and pop the warning configuration to avoid unintentional side effects. The previous solution could overwrite command line options and the inclusion of the header can change what warnings are enabled.
|
Hi, thanks for the fix. Did you find this "problem" by manual inspection or do you run some sort of automatic checker? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2462 +/- ##
=======================================
Coverage 78.18% 78.19%
=======================================
Files 486 486
Lines 32422 32422
=======================================
+ Hits 25349 25352 +3
+ Misses 7073 7070 -3
|
|
I run into this because including this header in the project I am working on made instances of this warning appear even though we have it disabled in our project files. |
quentin
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly push and pop the warning configuration to avoid unintentional side effects. The previous solution could overwrite command line options and the inclusion of the header can change what warnings are enabled.