Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise change event when setValue is used #25

Closed

Conversation

beverlyguillermo
Copy link

If you have a input fields and set the min/max values manually with the setValue method, the change event wasn't raised.

This change makes it happen, and just allows me to use the change hook that I already attached to the slider.

I didn't include a minified version of the change, I wasn't sure if what tool you used for the minification. If you let me know, I'll make a change to the patch.

Thanks!

@soundar24
Copy link
Owner

Thanks for your contribution @beverlyguillermo ...

Here we need to consider some additional points.. This should be applicable both "option" and "public method".. also need to consider at the initial time also..

This cause the behavior change since some place we used the current behavior only, so to handle this we need pass extra argument or any other. So i have created a separate bug for this, please track the below:
#26

@soundar24
Copy link
Owner

@beverlyguillermo This might be after a very long back, but a new update for you.

Now a new event valueChange was added with roundSlider from v1.5.0, which will be triggered at both user interaction as well as change through code.

Check more details here: https://github.com/soundar24/roundSlider/releases/tag/v1.5.0

Demo: https://jsfiddle.net/soundar24/r5jcb1q4/3/

Sorry for the long delay, now only I actively started to add new features and improvement... thanks for your support.

@soundar24 soundar24 closed this Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants