Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock Assessment API calls #113

Merged
merged 30 commits into from
Jun 20, 2018
Merged

Mock Assessment API calls #113

merged 30 commits into from
Jun 20, 2018

Conversation

remo5000
Copy link
Contributor

@remo5000 remo5000 commented Jun 18, 2018 •
edited by Aulud
Loading

Features

  • Assessment-related information is properly typed (with respect to the backend)
  • Sagas added to "mock" fetching from the API, but in reality fetches data from a file

Issues fixed

TODO

  • Add data types
  • Type the displayed data properly
    • Assessment/index
    • Academy/Missions (generalise dispatch)
  • Remove default mock data
  • Add sagas for fetching "data"

What's next

  • Generalise Missions to use for all 4 Assessment categories (using higher order or generics)
  • Generalise the button link and location parameter for Mission for all assessments

@remo5000 remo5000 changed the title [WIP] Mock Assessment API calls Mock Assessment API calls Jun 19, 2018
@remo5000 remo5000 requested a review from ning-y June 19, 2018 15:42
remo5000 added 28 commits June 19, 2018 23:48
@remo5000
Add /missions result
54b8ffe
@remo5000
Add closed and all missions
d945ea1 
Also added a counter for all the ids
@remo5000
Add mock questions
f21e6ee
@remo5000
Make assessment folder
c3b731e
@remo5000
Add types and interfaces for assessment api calls
91c9b8e
@remo5000
Match mock data to updated fields
172fb7d 
- Only closed assessment previews available (2 of them)
- 3 open assessment previews
- Changed dates to string
@remo5000
Make Questions use inheritence
25fbe93 
The union of interfaces seems to work.
@remo5000
Use IAssessment in Assessment component
51bbfe3
@remo5000
Change dispatch name in component
e136c98
@remo5000
Use proper variable names in AssessmentContainer
67c5896
@remo5000
Change state to use IAssessment
0995a31 
Also:
- Used `Array<T>` for definition in mock api
- Formatted AssessmentContainer
@remo5000
Use IAssessmentOverview in academy/missions
fc8f9d4 
Also removed category-specific assessments
@remo5000
Use IAssessmentOverview for Missions
3c01610 
Also added an enum for AssessmentCategory
@remo5000
Fix mission tests
8fcce49
@remo5000
Use assessment-related names in MissionsContainer
a10ac0f
@remo5000
Modify state to use IAssessmentOverview
f3080de
@remo5000
Modify mission info fetch action to assessment
21cf1d7
@remo5000
Fix linting and tests
402787d
@remo5000
Fix filtering issue for missions
534e56d 
The problem was with a faulty dataset.Also added
- Fix for not showing "loading" page (which was a mistake I made a few
commits ago)
- Spacing out for contentdisplay cards
@remo5000
Use enum category values
c5a10c1
@remo5000
Arrange fields in alphabetical order
388ff58
@remo5000
Format mockAPI
41b60d8
@remo5000
Make fetchAssessmentOverviews general
651a7d1 
This is because the API fetch is to fetch all the previews. Having the
parameter for category there, but not using it (or using it, resulting
in multiple calls for multiple categories) is not preferred.
@remo5000
Add saga for assessment overview fetching
3874ffd 
Note that the initial data is still not removed.
@remo5000
Add mock API fetch for assessment overviews
4a5fa48 
The default value for the overviews is now undefined so as to
simulate the fetching.
@remo5000
Format some files
9569116
@remo5000
Add API call for fetching assessment
66807b6 
Moved the fetch dispact in the academy/mission component from the render
function to the componentWillMount function, as we should not render
(due to content updates) while the render function is running.
@remo5000
Format and update test files
637d534
@coveralls
Copy link

coveralls commented Jun 20, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 25

  • 35 of 52 (67.31%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 30.409%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/assessment/index.tsx 1 5 20.0%
src/reducers/session.ts 1 5 20.0%
src/sagas/index.ts 4 13 30.77%
Totals Coverage Status
Change from base Build 16: 0.3%
Covered Lines: 1091
Relevant Lines: 3141
💛 - Coveralls

@ning-y ning-y merged commit b388c03 into master Jun 20, 2018
@ning-y ning-y deleted the mock-api-calls branch June 20, 2018 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ning-y ning-y ning-y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remo5000 @coveralls @ning-y