Update shape of Library #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not merging until backend implements source-academy/backend#149, since the site would probably crash otherwise. |
|
Note to self: do #207 once this is merged |
Loads all the globals into the window
I realise that the original way (this one) works best, and the only caveat is that we need to ensure that the assessment fetching causes an update
Since all the parts of Library are there, may as well use them.
and change a param name for PLAYGROUND_EXTERNAL_SELECT
- map externalLibraryName to uppercase - globals - map objects to array of tuples - try catch and eval
ning-y
approved these changes
Jul 26, 2018
Aulud
pushed a commit
to Aulud/cadet-frontend
that referenced
this pull request
May 25, 2020
Bumps [distillery](https://github.com/bitwalker/distillery) from 1.5.3 to 2.0.2. - [Release notes](https://github.com/bitwalker/distillery/releases) - [Changelog](https://github.com/bitwalker/distillery/blob/master/docs/changelog.md) - [Commits](bitwalker/distillery@1.5.3...2.0.2) Signed-off-by: dependabot[bot] <support@dependabot.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
globalsare used properly (see issue in cadet)filesproperty inLibraryhas been removedexternalshas been refactored toexternal, an object that containsnameand an array ofsymbolsReverted component updating for AssessmentWorkspace and GradingWorkspace (already merged in master)[location](made when fixing a bug)Resolves #188