Skip to content

Conversation

RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented Nov 27, 2022

Description

Migrate the following from class-based components to functional components:

  • src/commons/ContentDisplay.tsx
  • src/commons/achievement/AchievementTask.tsx
  • src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentAutograderTab.tsx
  • src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentGradingTab.tsx
  • src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentManageQuestionTab.tsx
  • src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentMcqQuestionTemplateTab.tsx
  • src/commons/profile/Profile.tsx
  • src/commons/sourceRecorder/SourceRecorderDeleteCell.tsx
  • src/pages/academy/dashboard/Dashboard.tsx
  • src/pages/academy/grading/subcomponents/GradingActionsCell.tsx
    • Also removed unused isAlertOpen state variable
  • src/pages/missionControl/MissionControl.tsx
    • Also remove unused editOverview state variable

As well as some minor code quality improvements in the above files.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Make sure everything still works.

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 requested a review from chownces November 27, 2022 03:29
@RichDom2185 RichDom2185 self-assigned this Nov 27, 2022
@coveralls
Copy link

coveralls commented Nov 27, 2022

Pull Request Test Coverage Report for Build 3696646508

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 42 of 130 (32.31%) changed or added relevant lines in 11 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.08%) to 32.87%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentGradingTab.tsx 1 3 33.33%
src/commons/profile/Profile.tsx 29 32 90.63%
src/commons/sourceRecorder/SourceRecorderDeleteCell.tsx 1 8 12.5%
src/pages/academy/grading/subcomponents/GradingActionsCell.tsx 1 9 11.11%
src/pages/missionControl/MissionControl.tsx 1 9 11.11%
src/pages/academy/dashboard/Dashboard.tsx 2 11 18.18%
src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentMcqQuestionTemplateTab.tsx 1 14 7.14%
src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentAutograderTab.tsx 1 17 5.88%
src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentManageQuestionTab.tsx 1 23 4.35%
Files with Coverage Reduction New Missed Lines %
src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentAutograderTab.tsx 1 4.76%
src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentGradingTab.tsx 1 25.0%
src/pages/academy/grading/subcomponents/GradingActionsCell.tsx 1 3.85%
src/pages/missionControl/MissionControl.tsx 1 10.53%
Totals Coverage Status
Change from base Build 3696637804: 0.08%
Covered Lines: 4342
Relevant Lines: 12286

💛 - Coveralls

Copy link
Contributor

@chownces chownces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chownces chownces merged commit bef6ee8 into source-academy:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants