Skip to content

Refactor remote execution #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 18, 2023
Merged

Refactor remote execution #2296

merged 13 commits into from
Jan 18, 2023

Conversation

RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented Dec 26, 2022 •
edited
Loading

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Just a minor refactor to separate the components better.

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 self-assigned this Dec 26, 2022
@RichDom2185 RichDom2185 changed the title Refactor Remote Execution Refactor remote execution Dec 26, 2022
@coveralls
Copy link

coveralls commented Dec 26, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3939619208

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 23 (4.35%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 34.433%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/sideContent/remoteExecution/DeviceMenuItemButtons.tsx 1 6 16.67%
src/commons/sideContent/remoteExecution/SideContentRemoteExecution.tsx 0 17 0.0%
Totals Coverage Status
Change from base Build 3931329556: -0.006%
Covered Lines: 4582
Relevant Lines: 12382
💛 - Coveralls

@RichDom2185 RichDom2185 requested a review from chownces January 17, 2023 12:14
@RichDom2185 RichDom2185 marked this pull request as ready for review January 17, 2023 12:14
RichDom2185 and others added 3 commits January 17, 2023 21:10
@RichDom2185
Refactor menu item buttons logic
065d801 
Improves abstraction of logic by moving handlers out of
`DeviceMenuItemButtons`.
@RichDom2185
Update types
cb6aced
@chownces
Merge branch 'master' into richard/refactor-remote-execution
9a8499a
chownces
chownces approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@chownces chownces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chownces chownces merged commit 34c7d77 into source-academy:master Jan 18, 2023
RichDom2185 added a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Jul 15, 2023
@RichDom2185 @chownces
Refactor remote execution (source-academy#2296)
1bc8dab 
* Move SideContentRemoteExecution

* Refactor DeviceMenuItemButtons

* Refactor menu item buttons logic

Improves abstraction of logic by moving handlers out of
`DeviceMenuItemButtons`.

* Update types

Co-authored-by: En Rong <53928333+chownces@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chownces chownces chownces approved these changes

Assignees

@RichDom2185 RichDom2185

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RichDom2185 @coveralls @chownces