-
Notifications
You must be signed in to change notification settings - Fork 173
Refactor navbar #2509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor navbar #2509
Conversation
080fad7
to
6bbe7bb
Compare
Pull Request Test Coverage Report for Build 5290926602Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The codebase is so much more readable now 😄 I only have some minor comments as follows.
Thanks for this long-overdue refactor!
src/commons/navigationBar/subcomponents/AcademyNavigationBar.tsx
Outdated
Show resolved
Hide resolved
f943f59
to
c65f8a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* Refactor navbar * Update navbar snapshots * Refactor AcademyNavigationBar * Fix snapshots * Fix PR comments * Fix snapshots --------- Co-authored-by: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
* Refactor navbar * Update navbar snapshots * Refactor AcademyNavigationBar * Fix snapshots * Fix PR comments * Fix snapshots --------- Co-authored-by: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
Description
Type of change
How to test
Checklist