Skip to content

Conversation

RichDom2185
Copy link
Member

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5769568346

  • 1 of 8 (12.5%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 37.434%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/stories/storiesComponents/SourceBlock.tsx 0 1 0.0%
src/features/stories/storiesComponents/StoriesSideContent.tsx 1 7 14.29%
Files with Coverage Reduction New Missed Lines %
src/features/stories/storiesComponents/StoriesSideContent.tsx 1 7.5%
Totals Coverage Status
Change from base Build 5768977868: -0.007%
Covered Lines: 5731
Relevant Lines: 14377

💛 - Coveralls

@RichDom2185 RichDom2185 enabled auto-merge (squash) August 5, 2023 14:03
@RichDom2185 RichDom2185 merged commit 7eccf63 into master Aug 5, 2023
@RichDom2185 RichDom2185 deleted the improve-sourceblock-ui branch August 5, 2023 14:10
RichDom2185 added a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Aug 6, 2023
* Make side content toggle button more descriptive

* Use standard run button for consistency

* Simplify code

* Fix output not showing

* Remove console log statements

* Remove unnecessary styles

* Remove unused class

* Allow specifying hidden body in StoriesSideContent

* Move hiding logic to StoriesSideContent component

* Remove unnecessary margin

* Use ControlButton for resetting stories env

Improves UI consistency with the rest of the codebase.
RichDom2185 added a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Aug 15, 2023
* Make side content toggle button more descriptive

* Use standard run button for consistency

* Simplify code

* Fix output not showing

* Remove console log statements

* Remove unnecessary styles

* Remove unused class

* Allow specifying hidden body in StoriesSideContent

* Move hiding logic to StoriesSideContent component

* Remove unnecessary margin

* Use ControlButton for resetting stories env

Improves UI consistency with the rest of the codebase.
@coveralls
Copy link

coveralls commented Sep 22, 2024

Pull Request Test Coverage Report for Build 5769568346

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 8 (12.5%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 37.434%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/stories/storiesComponents/SourceBlock.tsx 0 1 0.0%
src/features/stories/storiesComponents/StoriesSideContent.tsx 1 7 14.29%
Files with Coverage Reduction New Missed Lines %
src/features/stories/storiesComponents/StoriesSideContent.tsx 1 7.5%
Totals Coverage Status
Change from base Build 5768977868: -0.007%
Covered Lines: 5731
Relevant Lines: 14377

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants