Redesign MCQ choosing #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- One option on each line, spaced out. - minimal button that only shows a differnce when it is active.
Additionally: - Spread out the options
remo5000
commented
Aug 3, 2018
| * @param chosenOption the mcq option that is chosen in the state, i.e what should show up as "selected" | ||
| * @param solution the solution to the mcq, if any | ||
| */ | ||
| private getButtonIntent = ( |
There was a problem hiding this comment.
If possible could you review this with a bit more care? It looks ok to me, but feels like there might be come edge cases I haven't accounted for @ningyuansg
src/mocks/assessmentAPI.ts
Outdated
| choices: [ | ||
| { | ||
| content: 'A', | ||
| hint: 'hint A' |
There was a problem hiding this comment.
Remove hints for ungraded question. Inconsequential, but semantics matter.
| margin-bottom: 20px; | ||
| .pt-card { | ||
| background-color: $cadet-color-3; | ||
| .mcq-options-parent { |
There was a problem hiding this comment.
Nested some classes here, let me know if it's alright
Pull Request Test Coverage Report for Build 547
💛 - Coveralls |
ning-y
requested changes
Aug 3, 2018
There was a problem hiding this comment.
- Consider if
minimal={false}buttons for the options look better - Space between options and the left/right borders of the card should be the same as the space between options and the top/bottom borders of the card
- Disable the highlight after click on options using CSS (refer to the end of
_workspace.scss)
| </div> | ||
| <div className="MCQChooser row"> | ||
| <Card className="mcq-content-parent col-xs-12 middle-xs"> | ||
| <div className="row mcq-options-parent between-xs">{options}</div> |
There was a problem hiding this comment.
Put in button group to avoid weird gaps between the options.
ning-y
approved these changes
Aug 3, 2018
Aulud
pushed a commit
to Aulud/cadet-frontend
that referenced
this pull request
May 25, 2020
* Updated tests - /grading should show group * Augmented database query - now groups are visible * Updated Swagger Documentation * Updated tests - changed group to groupName * Style change to API - group now is groupName * Swagger Documentation Change for group to groupName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
solution(and hints):