Skip to content

Remove some hardcoded items #2634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 22, 2023
Merged

Remove some hardcoded items #2634

merged 3 commits into from
Aug 22, 2023

Conversation

RichDom2185
Copy link
Member

Description

  • Removes mention of CS1010R
  • Removes old (and unused) forum/LMS links
  • Removes all other unused links

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185
Remove CS1010R mention
ae5fd3b 
* No longer relevant in the semester
* Reduces hardcoding
@RichDom2185
Remove unused links
1044373
@RichDom2185 RichDom2185 self-assigned this Aug 19, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5910558789

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 37.428%
Totals Coverage Status
Change from base Build 5891888815: 0.0%
Covered Lines: 5739
Relevant Lines: 14413
💛 - Coveralls

@RichDom2185 RichDom2185 merged commit 6be7e8c into master Aug 22, 2023
@RichDom2185 RichDom2185 deleted the remove-hardcoding branch August 22, 2023 08:38
RichDom2185 added a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Aug 25, 2023
@RichDom2185
Remove some hardcoded items (source-academy#2634)
48fc5cc 
* Remove CS1010R mention

* No longer relevant in the semester
* Reduces hardcoding

* Remove unused links
RichDom2185 added a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Aug 25, 2023
@RichDom2185
Remove some hardcoded items (source-academy#2634)
c2ed9a0 
* Remove CS1010R mention

* No longer relevant in the semester
* Reduces hardcoding

* Remove unused links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chownces chownces chownces approved these changes

@martin-henz martin-henz Awaiting requested review from martin-henz

Assignees

@RichDom2185 RichDom2185

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RichDom2185 @coveralls @chownces