-
Notifications
You must be signed in to change notification settings - Fork 173
Reduce code duplication, standardise styling in SICP search #2707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bcc8c65
to
3230a53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us aim to merge these two PRs quickly due to the importance of this feature for upcoming exam revision.
Pull Request Test Coverage Report for Build 6709669490
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good update to make use of the BlueprintJS components! However, the issue of content overflow is present, and I am still trying to see if there is a resolution for that.
As for the search buttons themselves, are they still of relevance as right now? Right now I believe it will automatically show your search results through the autocomplete when search input is provided.
As discussed, this PR is simply a stepping stone to #2708. This PR only focuses on making the transition to Blueprint components (alongside some interface changes) to make the subsequent migration to use omnibox easier. Regarding the two issues:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, since this PR will be superseded by #2708 anyways, we can go ahead and merge it first. Everything seems to be working well except those in the aforementioned comment.
I will comment and add feedback on the more relevant changes over there instead. Thanks!
…cademy#2707) * Use BP Menu component for search results * Simplify more menus * Use BP MenuItem for IndexSearchResultsMenuEntry * Improve typing * Simplify index search results rendering * Use BP MenuItem for UserSearchResultsMenuEntry * Simplify text search results rendering * Improve layout
…cademy#2707) * Use BP Menu component for search results * Simplify more menus * Use BP MenuItem for IndexSearchResultsMenuEntry * Improve typing * Simplify index search results rendering * Use BP MenuItem for UserSearchResultsMenuEntry * Simplify text search results rendering * Improve layout
Description
Builds on #2706. Mainly an intermediate change (non-breaking), but simply done to:
in order to lay the groundwork for eventual migration to a much better UI for searching using omnibox (as discussed with @sayomaki over Telegram).
Type of change
How to test
Everything should still work with regards to SICP search.
Checklist