Add lumiNUS, piazza links to navbar #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

remo5000 merged 3 commits into master from navbar-changes

Aug 10, 2018

Member

ning-y commented Aug 10, 2018

Resolves #271.

ning-y added 3 commits

August 11, 2018 01:25


          Combine news, material navbuttons, redirect to lumiNUS

7860bb8


          Add Forum button to redirect to piazza

7f18dc7


          Change icons for News & Material

e1b159c

ning-y requested a review from remo5000

August 10, 2018 17:46

coveralls commented Aug 10, 2018

Pull Request Test Coverage Report for Build 602

3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 25.207%

Files with Coverage Reduction	New Missed Lines	%
src/containers/AnnouncementsContainer.ts	7	0.0%

Totals
Change from base Build 587:	-0.2%
Covered Lines:	848
Relevant Lines:	2844

💛 - Coveralls

remo5000 approved these changes

View reviewed changes

remo5000 merged commit 6141998 into master

ning-y deleted the navbar-changes branch

August 10, 2018 18:21

Aulud pushed a commit to Aulud/cadet-frontend that referenced this pull request


          Bump phoenix_ecto from 3.4.0 to 3.5.0 (source-academy#286)

a7d85f6

Bumps [phoenix_ecto](https://github.com/phoenixframework/phoenix_ecto) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/phoenixframework/phoenix_ecto/releases)
- [Changelog](https://github.com/phoenixframework/phoenix_ecto/blob/master/CHANGELOG.md)
- [Commits](phoenixframework/phoenix_ecto@v3.4.0...v3.5.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet