Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine Repl and Editor controls #75

Merged
merged 7 commits into from
May 31, 2018
Merged

Combine Repl and Editor controls #75

merged 7 commits into from
May 31, 2018

Conversation

ning-y
Copy link
Member

@ning-y ning-y commented May 31, 2018

Features

  • Repl and Editor controls are now in one ControlBar within workspace
  • None of the control buttons are hidden by resizing
  • Shift-enter now evaluates the editor
  • Tooltips appear on eval/run indicating that shift-enter can be used instead
  • Fix the chapter select caret not appearing by using @blueprintjs/select

Issues fixed

@ning-y ning-y requested a review from remo5000 May 31, 2018 08:12
@remo5000 remo5000 merged commit 182a005 into master May 31, 2018
@ning-y ning-y deleted the chapter-select branch June 2, 2018 17:00
Aulud pushed a commit to Aulud/cadet-frontend that referenced this pull request May 25, 2020
This reverts commit 9db2f0d4ba43e294f50c78025f3aaddd4ecb5e1f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants