Skip to content

Expose ExternalLibrary outside Playground, record ExternaLibrary change #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 1, 2019
Merged

Expose ExternalLibrary outside Playground, record ExternaLibrary change #796

merged 4 commits into from
Aug 1, 2019

Conversation

ccyccyccy
Copy link
Contributor

Allowed workspace locations other than Playground to access and change external library.

Recorded initial external library as well as change in external library in sourcecast

@ccyccyccy ccyccyccy requested a review from jiayushe August 1, 2019 09:22
@coveralls
Copy link

coveralls commented Aug 1, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2498

  • 9 of 28 (32.14%) changed or added relevant lines in 14 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 34.779%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Application.tsx 1 2 50.0%
src/containers/ApplicationContainer.ts 0 1 0.0%
src/containers/PlaygroundContainer.ts 0 1 0.0%
src/containers/sourcecast/SourcecastContainer.ts 0 1 0.0%
src/components/sourcecast/SourcecastControlbar.tsx 0 2 0.0%
src/components/sourcecast/SourcereelControlbar.tsx 0 2 0.0%
src/containers/sourcecast/SourcereelContainer.ts 0 2 0.0%
src/components/sourcecast/Sourcecast.tsx 0 3 0.0%
src/components/sourcecast/Sourcereel.tsx 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/sourcecast/SourcecastControlbar.tsx 1 6.59%
Totals Coverage Status
Change from base Build 2468: -0.07%
Covered Lines: 2183
Relevant Lines: 5566
💛 - Coveralls

jiayushe
jiayushe requested changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@jiayushe jiayushe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just make some minor changes to the action and state name.

@ccyccyccy ccyccyccy requested a review from jiayushe August 1, 2019 17:11
jiayushe
jiayushe reviewed Aug 1, 2019
View reviewed changes
@ccyccyccy ccyccyccy requested a review from jiayushe August 1, 2019 17:28
@jiayushe jiayushe merged commit a325012 into master Aug 1, 2019
@Aulud Aulud mentioned this pull request Aug 2, 2019
Closed
@geshuming geshuming deleted the sourcecast-library branch August 9, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiayushe jiayushe jiayushe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccyccyccy @coveralls @jiayushe