parse_int function does not match ECMAscript specification

[Wingedevil]

parse_int("1",36); // returns 1 intended behavior
parse_int("1",46);
parse_int("uu1",36);

"Error: parseInt expects two arguments a string s, and a positive integer i" is thrown while both arguments are as stated in the error. In addition, according to ECMAScript specification, a NaN is returned for these two cases.

[ning-y]

@martin-henz Are we following ES specs and returning NaN here?

@Wingedevil Either way, the fix is quite trivial. You can try it yourself if you like at

js-slang/src/stdlib/misc.ts

Line 48 in 3464f4d

if (inputString && radix && parsed) {

. Otherwise, somebody will fix this soon.

[martin-henz]

@martin-henz Are we following ES specs and returning NaN here?

Yes, of course. We are following ES specs. Note that the second argument is not optional in Source. As usual, Source is clearer and simpler than ES, but everything that runs in Source should run exactly in the same way in any native ES implementation.