Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Source §3 Non-Det in SICP JS 4.3.1 and 4.3.2 by the interpreter from SICP JS 4.3.3 #990

Open
martin-henz opened this issue Apr 27, 2024 · 1 comment

Comments

@martin-henz
Copy link
Member

martin-henz commented Apr 27, 2024

This will allow us to retire the folder src/interpreter and reduce the number of execution engines we need to support. To make the examples of 4.3.1 and 4.3.2 work, the repl module will come in handy.

Currently, Source §3 Non-Det is not working. Older version works. E.g. the first example in SICP JS 4.3
https://sourceacademy.nus.edu.sg/sicpjs/4.3.1
works without error (but with spacing issues). (currently deployment of SA@NUS of today)

The newest version in SA.org gives a runtime error:
https://share.sourceacademy.org/s9irv
gives:

main.13f449e4.js:2 RangeError: Maximum call stack size exceeded

This is regardless whether the amb operator is used.

display(1);

gives the same error. Source §3 Non-Det does not work at all, currently.

@martin-henz martin-henz changed the title Source §3 Non-Det stopped working Implement Source §3 Non-Det using call-with-current-continuation Apr 27, 2024
@martin-henz martin-henz changed the title Implement Source §3 Non-Det using call-with-current-continuation Replace Source §3 Non-Det in SICP JS by the interpreter from SICP JS 4.3.3 Apr 27, 2024
@martin-henz martin-henz changed the title Replace Source §3 Non-Det in SICP JS by the interpreter from SICP JS 4.3.3 Replace Source §3 Non-Det in SICP JS 4.3.1 and 4.3.2 by the interpreter from SICP JS 4.3.3 Apr 27, 2024
@martin-henz martin-henz transferred this issue from source-academy/js-slang Apr 27, 2024
@martin-henz
Copy link
Member Author

Requires a new feature in the REPL module, see source-academy/modules#317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant